Add BUILD.gn files for chromecast/media

chromecast/BUILD.gn

+# Copyright 2015 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+import("//chromecast/chromecast.gni")

[brettw, 2015/04/21 16:39:09]

Blank line before this.

[prashantv, 2015/04/21 18:21:35]

Done.

+
+config("config") {
+  # TODO(gyp) propagate this to webkit for chromecast builds.

[gunsch, 2015/04/21 02:09:43]

do defines propagate to all includers if they live in chromecast.gni?

[brettw, 2015/04/21 16:39:09]

These will get applied to all targets with this config applied. This is
generally done explicitly, which you can see in chromecast/media/base/BUILD.gn.

However, I suspect you'll also want to apply this to the other chromecast
targets, right?

[prashantv, 2015/04/21 18:21:35]

Yes, I was hoping to automatically propagate this to all targets under
chromecast. Is there any way to do that? For now, I'll add it to the targets
explicitly.

[brettw, 2015/04/21 19:25:12]

No. The closest you can get is to add a public_config on a target that
everything in here depends on. But it doesn't seem like you have that structure.
Also, the public_config thing will leak out into other non-chromecast targets
which you probably don't want in this case.

[gunsch, 2015/04/21 20:58:17]

Brett: we need to enable Blink logging in production Chromecast builds, which is
why we set LOG_DISABLED=0 in our build/common.gypi block. How would be most
appropriate to do an equivalent for GN? It looks like GYP at least has a
"blink_logging_always_on" GYP define that can be set, should we look into adding
a GN equivalent?

Prashant: we do want this define, but it's not really useful within chromecast/.
Can you remove it for now and add a TODO about this in chromecast/build/args.gn?

+  defines = [ "LOG_DISABLED=0" ]
+
+  if (use_playready) {
+    defines += [ "PLAYREADY_CDM_AVAILABLE" ]
+  }
+}
+
+# TODO(gyp): Figure out how to propagate config to everything under chromecast.

[gunsch, 2015/04/21 02:09:43]

what does this mean? do you mean that args you set don't apply to all GN files
under src/chromecast/, or something else?

[brettw, 2015/04/21 16:39:09]

See above, just apply the config to all the targets.

[prashantv, 2015/04/21 18:21:35]

Done.

+
+component("chromecast") {
+  deps = [
+    "//chromecast/base",
+    "//chromecast/base/metrics",
+    "//chromecast/media",
+  ]
+}