chromecast/chromecast.gni - Issue 1055173005: Add BUILD.gn files for chromecast/media

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chromecast/chromecast.gni

Issue 1055173005: Add BUILD.gn files for chromecast/media (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 declare_args() {
	brettw 2015/04/21 16:39:09 Copyright block. Copyright block. prashantv 2015/04/21 18:21:36 Done. Show quoted text On 2015/04/21 16:39:09, brettw wrote: > Copyright block. Done.
	2 # chromecast_branding is set to "Chrome" for an official build

	3 chromecast_branding = "Chromium"
	brettw 2015/04/21 16:39:09 You can choose how you want to do this. Since ther You can choose how you want to do this. Since there are only two values we'll ever have, I made the chrome branding one a boolean: is_chrome_branded. This makes typos impossible and means you don't have hardcoded strings floating around. So I would suggest (optional) is_chromecast_chrome_branded or something. prashantv 2015/04/21 18:21:36 Done. Show quoted text On 2015/04/21 16:39:09, brettw wrote: > You can choose how you want to do this. Since there are only two values we'll > ever have, I made the chrome branding one a boolean: is_chrome_branded. This > makes typos impossible and means you don't have hardcoded strings floating > around. So I would suggest (optional) is_chromecast_chrome_branded or something. Done.
	4

	5 use_playready = true

	6 }

OLD	NEW