chromecast/args.gn - Issue 1055173005: Add BUILD.gn files for chromecast/media

Side by Side Diff: chromecast/args.gn

Issue 1055173005: Add BUILD.gn files for chromecast/media (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Build arguments for Chromecast.
	gunsch 2015/04/21 02:09:43 Since this isn't actually a gn file itself, how ab Since this isn't actually a gn file itself, how about putting it into a script like "chromecast/build/setup_gn_args.sh" brettw 2015/04/21 16:39:09 Since the suggestion is that you copy and paste th Show quoted text On 2015/04/21 02:09:43, gunsch wrote: > Since this isn't actually a gn file itself, how about putting it into a script > like "chromecast/build/setup_gn_args.sh" Since the suggestion is that you copy and paste this, the file extension seems appropriate. It's in GN format, and it's not a shell script. prashantv 2015/04/21 18:21:35 I'm using args.gn since that's the actual filename Show quoted text On 2015/04/21 16:39:09, brettw wrote: > On 2015/04/21 02:09:43, gunsch wrote: > > Since this isn't actually a gn file itself, how about putting it into a script > > like "chromecast/build/setup_gn_args.sh" > > Since the suggestion is that you copy and paste this, the file extension seems > appropriate. It's in GN format, and it's not a shell script. I'm using args.gn since that's the actual filename for the file inside the out folder. You can run gn args, and copy this file to the out directly, so figured I should call it this. gunsch 2015/04/21 20:58:18 OK, can you move to chromecast/build/args.gn thoug Show quoted text On 2015/04/21 18:21:35, prashantv wrote: > On 2015/04/21 16:39:09, brettw wrote: > > On 2015/04/21 02:09:43, gunsch wrote: > > > Since this isn't actually a gn file itself, how about putting it into a > script > > > like "chromecast/build/setup_gn_args.sh" > > > > Since the suggestion is that you copy and paste this, the file extension seems > > appropriate. It's in GN format, and it's not a shell script. > > I'm using args.gn since that's the actual filename for the file inside the out > folder. You can run gn args, and copy this file to the out directly, so figured > I should call it this. OK, can you move to chromecast/build/args.gn though?
	2 # Copy the contents of this file to gn args.

	3

	4 root_extra_deps = [ "//chromecast" ]

	5

	6 # Flags set from build/common.gypi

	7 enable_mpeg2ts_stream_parser = true

	8 ffmpeg_branding = "ChromeOS"

	9 proprietary_codecs = true

	10 enable_browser_cdms = true

	11 # TODO: should we set these flags:

	12 # ozone_platform_cast = 1
	gunsch 2015/04/21 02:09:43 Yes, but this isn't necessarily where they apply c Yes, but this isn't necessarily where they apply chromecast/args.gn. prashantv 2015/04/21 18:21:35 Should I delete this for now from here then? Show quoted text On 2015/04/21 02:09:43, gunsch wrote: > Yes, but this isn't necessarily where they apply chromecast/args.gn. Should I delete this for now from here then?
	13 # disable_display: 0
	gunsch 2015/04/21 02:09:43 doesn't need to be set explicitly, as long as it d doesn't need to be set explicitly, as long as it defaults to 0 in the .gni prashantv 2015/04/21 18:21:35 Done. Show quoted text On 2015/04/21 02:09:43, gunsch wrote: > doesn't need to be set explicitly, as long as it defaults to 0 in the .gni Done.
	14 # enable_default_cast_graphics: 1
	gunsch 2015/04/21 02:09:43 same comment as disable_display same comment as disable_display prashantv 2015/04/21 18:21:35 Done. Show quoted text On 2015/04/21 02:09:43, gunsch wrote: > same comment as disable_display Done.
	15 # ozone_platform_cast: 0
	gunsch 2015/04/21 02:09:43 dupe to above dupe to above prashantv 2015/04/21 18:21:36 Done. Show quoted text On 2015/04/21 02:09:43, gunsch wrote: > dupe to above Done.
	16 # use_chromecast_Webui: 0
	gunsch 2015/04/21 02:09:43 same comment as disable_display same comment as disable_display prashantv 2015/04/21 18:21:36 Done. Show quoted text On 2015/04/21 02:09:43, gunsch wrote: > same comment as disable_display Done.
OLD	NEW

« chromecast/BUILD.gn ('K') | « chromecast/BUILD.gn ('k') | chromecast/base/BUILD.gn » ('j') | chromecast/base/BUILD.gn » ('J')