chromecast/base/BUILD.gn - Issue 1055173005: Add BUILD.gn files for chromecast/media

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chromecast/base/BUILD.gn

Issue 1055173005: Add BUILD.gn files for chromecast/media (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 # Copyright (c) 2015 The Chromium Authors. All rights reserved.
	gunsch 2015/04/21 02:09:43 this file and elsewhere: rm the (c) this file and elsewhere: rm the (c) prashantv 2015/04/21 18:21:36 Done. Show quoted text On 2015/04/21 02:09:43, gunsch wrote: > this file and elsewhere: rm the (c) Done.
	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 component("base") {
	brettw 2015/04/21 16:39:09 I'm suspicious whether we actually want a full sha I'm suspicious whether we actually want a full shared library for one .cc file of a few paths. I would normally make this kind of thing a source_set. If there's a good technical reason for the component, it's OK. You'll want to apply the config with the defines in it. prashantv 2015/04/21 18:21:36 Done. Show quoted text On 2015/04/21 16:39:09, brettw wrote: > I'm suspicious whether we actually want a full shared library for one .cc file > of a few paths. I would normally make this kind of thing a source_set. If > there's a good technical reason for the component, it's OK. > > You'll want to apply the config with the defines in it. Done.
	6 sources = [

	7 "cast_paths.cc",

	8 "cast_paths.h",

	9 ]

	10 }

OLD	NEW