Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Issue 1054573002: Implement support for notification.vibrate (Closed)

Created:
5 years, 8 months ago by Sanghyun Park
Modified:
5 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mlamouri+watch-notifications_chromium.org, peter+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement support for notification.vibrate This patch implements support for notification.vibrate, which allow a Web developer to set the "vibrate" key when creating a notification, that will set up a vibration. This operation depends on the device capability. Currently this only works on Android. The Web Notification specification: https://notifications.spec.whatwg.org/#dom-notificationoptions-vibrate BUG=442132 Committed: https://crrev.com/1593bf8e67c4e99be94a85bec217463961a9c07c Cr-Commit-Position: refs/heads/master@{#329082}

Patch Set 1 : #

Total comments: 51

Patch Set 2 : #

Total comments: 16

Patch Set 3 : #

Total comments: 19

Patch Set 4 : #

Total comments: 7

Patch Set 5 : #

Total comments: 9

Patch Set 6 : #

Total comments: 8

Patch Set 7 : #

Total comments: 8

Patch Set 8 : #

Total comments: 2

Patch Set 9 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -8 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java View 1 2 3 3 chunks +50 lines, -4 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationUIManagerTest.java View 1 2 3 2 chunks +32 lines, -0 lines 0 comments Download
M chrome/browser/notifications/notification_ui_manager_android.cc View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/notifications/platform_notification_service_browsertest.cc View 1 2 3 4 5 6 3 chunks +25 lines, -0 lines 0 comments Download
M chrome/browser/notifications/platform_notification_service_impl.cc View 1 2 3 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/notifications/platform_notification_service_unittest.cc View 1 2 3 4 5 6 3 chunks +12 lines, -0 lines 0 comments Download
M chrome/test/data/notifications/platform_notification_service.html View 1 1 chunk +8 lines, -0 lines 0 comments Download
M content/browser/notifications/notification_database_data.proto View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/notifications/notification_database_data_conversions.cc View 1 2 3 4 5 6 2 chunks +11 lines, -0 lines 0 comments Download
M content/browser/notifications/notification_database_data_unittest.cc View 1 2 3 4 5 6 4 chunks +11 lines, -0 lines 0 comments Download
M content/browser/notifications/notification_message_filter.cc View 1 2 3 4 5 6 7 8 4 chunks +26 lines, -3 lines 0 comments Download
M content/child/notifications/notification_data_conversions.cc View 1 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download
M content/child/notifications/notification_data_conversions_unittest.cc View 1 2 3 4 5 6 7 7 chunks +20 lines, -0 lines 0 comments Download
M content/common/platform_notification_messages.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/platform_notification_data.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M ui/message_center/notification.h View 1 2 3 2 chunks +10 lines, -0 lines 0 comments Download
M ui/message_center/notification.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 49 (21 generated)
Sanghyun Park
dcheng@chromium.org: Please review changes in avi@chromium.org: Please review changes in peter@chromium.org: Please review changes in
5 years, 8 months ago (2015-04-21 16:57:50 UTC) #10
Avi (use Gerrit)
https://codereview.chromium.org/1054573002/diff/160001/content/browser/notifications/notification_database_data.proto File content/browser/notifications/notification_database_data.proto (right): https://codereview.chromium.org/1054573002/diff/160001/content/browser/notifications/notification_database_data.proto#newcode24 content/browser/notifications/notification_database_data.proto:24: // Next tag: 8 ? https://codereview.chromium.org/1054573002/diff/160001/content/browser/notifications/notification_database_data.proto#newcode39 content/browser/notifications/notification_database_data.proto:39: optional bytes ...
5 years, 8 months ago (2015-04-21 17:28:47 UTC) #11
Peter Beverloo
Hi Sanghyun, Here's my review. Please note that I'm out of office on Thursday and ...
5 years, 8 months ago (2015-04-21 17:58:24 UTC) #13
Sanghyun Park
Dear Peter and Avi. Thanks for kind reviews!! I'll fix these. Thank you very much!! ...
5 years, 8 months ago (2015-04-23 11:08:27 UTC) #14
Peter Beverloo
Thank you! I've got a few more comments. https://codereview.chromium.org/1054573002/diff/160001/chrome/browser/notifications/notification_ui_manager_android.cc File chrome/browser/notifications/notification_ui_manager_android.cc (right): https://codereview.chromium.org/1054573002/diff/160001/chrome/browser/notifications/notification_ui_manager_android.cc#newcode122 chrome/browser/notifications/notification_ui_manager_android.cc:122: if ...
5 years, 8 months ago (2015-04-26 23:26:41 UTC) #17
Sanghyun Park
Thanks for your reviews! I'll update patch.:) https://codereview.chromium.org/1054573002/diff/220001/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java File chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java (right): https://codereview.chromium.org/1054573002/diff/220001/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java#newcode306 chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java:306: * @param ...
5 years, 8 months ago (2015-04-27 14:00:00 UTC) #18
Peter Beverloo
Hi Sanghyun Park, Thank you for the update! The remainder of my comments are mostly ...
5 years, 7 months ago (2015-05-01 17:17:59 UTC) #21
Sanghyun Park
> patch set if you don't post a comment after uploading it. > Generally, people ...
5 years, 7 months ago (2015-05-04 07:00:44 UTC) #22
Sanghyun Park
Dear Peter. Please take another look. Thanks!
5 years, 7 months ago (2015-05-04 16:00:36 UTC) #25
Peter Beverloo
Cool, thanks! One last comment :-) https://codereview.chromium.org/1054573002/diff/280001/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationUIManagerTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationUIManagerTest.java (right): https://codereview.chromium.org/1054573002/diff/280001/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationUIManagerTest.java#newcode404 chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationUIManagerTest.java:404: NotificationUIManager.makeVibratePattern(new int[] {100, ...
5 years, 7 months ago (2015-05-05 13:11:56 UTC) #26
Sanghyun Park
Thanks for your reviews. :) I uploaded new patch. https://codereview.chromium.org/1054573002/diff/340001/chrome/browser/notifications/platform_notification_service_browsertest.cc File chrome/browser/notifications/platform_notification_service_browsertest.cc (right): https://codereview.chromium.org/1054573002/diff/340001/chrome/browser/notifications/platform_notification_service_browsertest.cc#newcode32 chrome/browser/notifications/platform_notification_service_browsertest.cc:32: ...
5 years, 7 months ago (2015-05-05 17:54:31 UTC) #28
Peter Beverloo
lgtm! Thank you for your patience! Now comes the OWNERs dance.. https://codereview.chromium.org/1054573002/diff/380001/chrome/browser/notifications/platform_notification_service_impl.cc File chrome/browser/notifications/platform_notification_service_impl.cc (right): ...
5 years, 7 months ago (2015-05-05 20:42:44 UTC) #29
Avi (use Gerrit)
This seems pretty simple to me. LGTM with question. https://codereview.chromium.org/1054573002/diff/380001/content/browser/notifications/notification_database_data.proto File content/browser/notifications/notification_database_data.proto (right): https://codereview.chromium.org/1054573002/diff/380001/content/browser/notifications/notification_database_data.proto#newcode37 content/browser/notifications/notification_database_data.proto:37: ...
5 years, 7 months ago (2015-05-05 20:53:59 UTC) #30
dcheng
https://codereview.chromium.org/1054573002/diff/380001/chrome/browser/notifications/platform_notification_service_impl.cc File chrome/browser/notifications/platform_notification_service_impl.cc (right): https://codereview.chromium.org/1054573002/diff/380001/chrome/browser/notifications/platform_notification_service_impl.cc#newcode331 chrome/browser/notifications/platform_notification_service_impl.cc:331: // trust any values passed from the client. I'd ...
5 years, 7 months ago (2015-05-05 21:56:33 UTC) #31
Sanghyun Park
Dear Peter, Avi and dcheng. Thanks so much for review!! :) https://codereview.chromium.org/1054573002/diff/380001/chrome/browser/notifications/platform_notification_service_impl.cc File chrome/browser/notifications/platform_notification_service_impl.cc (right): ...
5 years, 7 months ago (2015-05-06 14:53:26 UTC) #32
Peter Beverloo
https://codereview.chromium.org/1054573002/diff/380001/chrome/browser/notifications/platform_notification_service_impl.cc File chrome/browser/notifications/platform_notification_service_impl.cc (right): https://codereview.chromium.org/1054573002/diff/380001/chrome/browser/notifications/platform_notification_service_impl.cc#newcode331 chrome/browser/notifications/platform_notification_service_impl.cc:331: // trust any values passed from the client. On ...
5 years, 7 months ago (2015-05-06 15:35:18 UTC) #33
Sanghyun Park
https://codereview.chromium.org/1054573002/diff/380001/chrome/browser/notifications/platform_notification_service_impl.cc File chrome/browser/notifications/platform_notification_service_impl.cc (right): https://codereview.chromium.org/1054573002/diff/380001/chrome/browser/notifications/platform_notification_service_impl.cc#newcode331 chrome/browser/notifications/platform_notification_service_impl.cc:331: // trust any values passed from the client. On ...
5 years, 7 months ago (2015-05-06 17:33:32 UTC) #35
dcheng
https://codereview.chromium.org/1054573002/diff/440001/content/browser/notifications/notification_database_data_conversions.cc File content/browser/notifications/notification_database_data_conversions.cc (right): https://codereview.chromium.org/1054573002/diff/440001/content/browser/notifications/notification_database_data_conversions.cc#newcode42 content/browser/notifications/notification_database_data_conversions.cc:42: if (payload.vibration_pattern().size()) { empty() instead of size() makes this ...
5 years, 7 months ago (2015-05-06 18:43:27 UTC) #37
Sanghyun Park
Dear Daniel. Thanks for your comments. I had fix these. Please take another look. https://codereview.chromium.org/1054573002/diff/440001/content/browser/notifications/notification_database_data_conversions.cc ...
5 years, 7 months ago (2015-05-07 12:08:33 UTC) #38
dcheng
https://codereview.chromium.org/1054573002/diff/460001/content/browser/notifications/notification_message_filter.cc File content/browser/notifications/notification_message_filter.cc (right): https://codereview.chromium.org/1054573002/diff/460001/content/browser/notifications/notification_message_filter.cc#newcode20 content/browser/notifications/notification_message_filter.cc:20: namespace { Move the unnamed namespace into the content ...
5 years, 7 months ago (2015-05-07 22:08:40 UTC) #39
Sanghyun Park
Thanks !! I had updated about theses. https://codereview.chromium.org/1054573002/diff/460001/content/browser/notifications/notification_message_filter.cc File content/browser/notifications/notification_message_filter.cc (right): https://codereview.chromium.org/1054573002/diff/460001/content/browser/notifications/notification_message_filter.cc#newcode20 content/browser/notifications/notification_message_filter.cc:20: namespace { ...
5 years, 7 months ago (2015-05-08 05:23:13 UTC) #40
dcheng
https://codereview.chromium.org/1054573002/diff/480001/content/browser/notifications/notification_message_filter.cc File content/browser/notifications/notification_message_filter.cc (right): https://codereview.chromium.org/1054573002/diff/480001/content/browser/notifications/notification_message_filter.cc#newcode29 content/browser/notifications/notification_message_filter.cc:29: PlatformNotificationData sanitized_data; My point was that you could make ...
5 years, 7 months ago (2015-05-08 20:22:27 UTC) #41
Sanghyun Park
Dear Daniel. Thanks for your advise. PTAL :) https://codereview.chromium.org/1054573002/diff/480001/content/browser/notifications/notification_message_filter.cc File content/browser/notifications/notification_message_filter.cc (right): https://codereview.chromium.org/1054573002/diff/480001/content/browser/notifications/notification_message_filter.cc#newcode29 content/browser/notifications/notification_message_filter.cc:29: PlatformNotificationData ...
5 years, 7 months ago (2015-05-09 15:07:13 UTC) #42
dcheng
lgtm
5 years, 7 months ago (2015-05-09 17:20:52 UTC) #43
Sanghyun Park
Dear All. Thanks so much for your help about this. :)
5 years, 7 months ago (2015-05-10 12:50:42 UTC) #44
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1054573002/500001
5 years, 7 months ago (2015-05-10 12:51:06 UTC) #47
commit-bot: I haz the power
Committed patchset #9 (id:500001)
5 years, 7 months ago (2015-05-10 21:30:18 UTC) #48
commit-bot: I haz the power
5 years, 7 months ago (2015-05-10 21:31:16 UTC) #49
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/1593bf8e67c4e99be94a85bec217463961a9c07c
Cr-Commit-Position: refs/heads/master@{#329082}

Powered by Google App Engine
This is Rietveld 408576698