Implement support for notification.vibrate

chrome/browser/notifications/platform_notification_service_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/strings/utf_string_conversions.h"
 #include "base/threading/platform_thread.h"
 #include "base/time/time.h"
 #include "chrome/browser/notifications/notification_test_util.h"
 #include "chrome/browser/notifications/platform_notification_service_impl.h"
 #include "chrome/test/base/testing_profile.h"
 #include "components/content_settings/core/browser/host_content_settings_map.h"
 #include "content/public/browser/desktop_notification_delegate.h"
 #include "content/public/common/platform_notification_data.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 
 namespace {
 
+const unsigned kNotificationVibrate[] = { 100, 200, 300 };

[Peter Beverloo, 2015/04/21 17:58:23]

nit: blank line

[Peter Beverloo, 2015/04/21 17:58:23]

Please use either int or int64_t here.

[Sanghyun Park, 2015/04/23 11:08:26]

Done.

 #if !defined(OS_ANDROID)
 const int64_t kPersistentNotificationId = 42;
 #endif
 
 class MockDesktopNotificationDelegate
     : public content::DesktopNotificationDelegate {
  public:
   MockDesktopNotificationDelegate()
       : displayed_(false),
         clicked_(false) {}
@@ skipping 120 matching lines @@
       base::UTF16ToUTF8(notification.title()));
   EXPECT_EQ("Hello, world!",
       base::UTF16ToUTF8(notification.message()));
 
   service()->ClosePersistentNotification(profile(), kPersistentNotificationId);
   EXPECT_EQ(0u, ui_manager()->GetNotificationCount());
 }
 #endif  // !defined(OS_ANDROID)
 
 TEST_F(PlatformNotificationServiceTest, DisplayPageNotificationMatches) {
+  std::vector<unsigned> vibrate_pattern(

[Peter Beverloo, 2015/04/21 17:58:23]

int/int64_t (whatever you choose to use in the //content API)

[Sanghyun Park, 2015/04/23 11:08:26]

Done.

+      kNotificationVibrate,
+      kNotificationVibrate + arraysize(kNotificationVibrate));
+
   content::PlatformNotificationData notification_data;
   notification_data.title = base::ASCIIToUTF16("My notification's title");
   notification_data.body = base::ASCIIToUTF16("Hello, world!");
+  notification_data.vibrate = vibrate_pattern;
   notification_data.silent = true;
 
   MockDesktopNotificationDelegate* delegate
       = new MockDesktopNotificationDelegate();
   service()->DisplayNotification(profile(),
                                  GURL("https://chrome.com/"),
                                  SkBitmap(),
                                  notification_data,
                                  make_scoped_ptr(delegate),
                                  nullptr);
 
   ASSERT_EQ(1u, ui_manager()->GetNotificationCount());
 
   const Notification& notification = ui_manager()->GetNotificationAt(0);
   EXPECT_EQ("https://chrome.com/", notification.origin_url().spec());
   EXPECT_EQ("My notification's title",
       base::UTF16ToUTF8(notification.title()));
   EXPECT_EQ("Hello, world!",
       base::UTF16ToUTF8(notification.message()));
+
+  ASSERT_EQ(vibrate_pattern.size(), notification.vibrate().size());
+  for (size_t i = 0; i < vibrate_pattern.size(); ++i)
+    EXPECT_EQ(vibrate_pattern[i], notification.vibrate()[i]);
+
   EXPECT_TRUE(notification.silent());
 }
 
 TEST_F(PlatformNotificationServiceTest, DisplayNameForOrigin) {
   base::string16 display_name =
       service()->DisplayNameForOrigin(profile(), GURL("https://chrome.com/"));
 
   EXPECT_EQ(base::ASCIIToUTF16("chrome.com"), display_name);
 
   // TODO(peter): Include unit tests for the extension-name translation
@@ skipping 59 matching lines @@
 
   service()->DisplayPersistentNotification(
       profile(), 42 /* sw_registration_id */, origin, SkBitmap(),
       content::PlatformNotificationData());
 
   base::Time after_persistent_notification =
       profile()->GetHostContentSettingsMap()->GetLastUsage(
           origin, origin, CONTENT_SETTINGS_TYPE_NOTIFICATIONS);
   EXPECT_GT(after_persistent_notification, after_page_notification);
 }