Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Side by Side Diff: content/child/notifications/notification_data_conversions_unittest.cc

Issue 1054573002: Implement support for notification.vibrate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/child/notifications/notification_data_conversions.h" 5 #include "content/child/notifications/notification_data_conversions.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "content/public/common/platform_notification_data.h" 10 #include "content/public/common/platform_notification_data.h"
11 #include "testing/gtest/include/gtest/gtest.h" 11 #include "testing/gtest/include/gtest/gtest.h"
12 #include "third_party/WebKit/public/platform/WebString.h" 12 #include "third_party/WebKit/public/platform/WebString.h"
13 #include "third_party/WebKit/public/platform/WebURL.h" 13 #include "third_party/WebKit/public/platform/WebURL.h"
14 #include "third_party/WebKit/public/platform/modules/notifications/WebNotificati onData.h" 14 #include "third_party/WebKit/public/platform/modules/notifications/WebNotificati onData.h"
15 15
16 namespace content { 16 namespace content {
17 17
18 const char kNotificationTitle[] = "My Notification"; 18 const char kNotificationTitle[] = "My Notification";
19 const char kNotificationLang[] = "nl"; 19 const char kNotificationLang[] = "nl";
20 const char kNotificationBody[] = "Hello, world!"; 20 const char kNotificationBody[] = "Hello, world!";
21 const char kNotificationTag[] = "my_tag"; 21 const char kNotificationTag[] = "my_tag";
22 const char kNotificationIconUrl[] = "https://example.com/icon.png"; 22 const char kNotificationIconUrl[] = "https://example.com/icon.png";
23 const unsigned kNotificationVibrate[] = { 100, 200, 300 };
23 const unsigned char kNotificationData[] = { 0xdf, 0xff, 0x0, 0x0, 0xff, 0xdf }; 24 const unsigned char kNotificationData[] = { 0xdf, 0xff, 0x0, 0x0, 0xff, 0xdf };
24 25
25 TEST(NotificationDataConversionsTest, ToPlatformNotificationData) { 26 TEST(NotificationDataConversionsTest, ToPlatformNotificationData) {
27 std::vector<unsigned> vibrate_pattern(
Peter Beverloo 2015/04/21 17:58:23 dito re: types in this file.
Sanghyun Park 2015/04/23 11:08:26 Done.
28 kNotificationVibrate,
29 kNotificationVibrate + arraysize(kNotificationVibrate));
30
26 std::vector<char> developer_data( 31 std::vector<char> developer_data(
27 kNotificationData, kNotificationData + arraysize(kNotificationData)); 32 kNotificationData, kNotificationData + arraysize(kNotificationData));
28 33
29 blink::WebNotificationData web_data( 34 blink::WebNotificationData web_data(
30 blink::WebString::fromUTF8(kNotificationTitle), 35 blink::WebString::fromUTF8(kNotificationTitle),
31 blink::WebNotificationData::DirectionLeftToRight, 36 blink::WebNotificationData::DirectionLeftToRight,
32 blink::WebString::fromUTF8(kNotificationLang), 37 blink::WebString::fromUTF8(kNotificationLang),
33 blink::WebString::fromUTF8(kNotificationBody), 38 blink::WebString::fromUTF8(kNotificationBody),
34 blink::WebString::fromUTF8(kNotificationTag), 39 blink::WebString::fromUTF8(kNotificationTag),
35 blink::WebURL(GURL(kNotificationIconUrl)), 40 blink::WebURL(GURL(kNotificationIconUrl)),
41 blink::WebVector<unsigned>(vibrate_pattern),
36 true /* silent */, 42 true /* silent */,
37 blink::WebVector<char>(developer_data)); 43 blink::WebVector<char>(developer_data));
38 44
39 PlatformNotificationData platform_data = ToPlatformNotificationData(web_data); 45 PlatformNotificationData platform_data = ToPlatformNotificationData(web_data);
40 EXPECT_EQ(base::ASCIIToUTF16(kNotificationTitle), platform_data.title); 46 EXPECT_EQ(base::ASCIIToUTF16(kNotificationTitle), platform_data.title);
41 EXPECT_EQ(PlatformNotificationData::NotificationDirectionLeftToRight, 47 EXPECT_EQ(PlatformNotificationData::NotificationDirectionLeftToRight,
42 platform_data.direction); 48 platform_data.direction);
43 EXPECT_EQ(kNotificationLang, platform_data.lang); 49 EXPECT_EQ(kNotificationLang, platform_data.lang);
44 EXPECT_EQ(base::ASCIIToUTF16(kNotificationBody), platform_data.body); 50 EXPECT_EQ(base::ASCIIToUTF16(kNotificationBody), platform_data.body);
45 EXPECT_EQ(kNotificationTag, platform_data.tag); 51 EXPECT_EQ(kNotificationTag, platform_data.tag);
46 EXPECT_EQ(kNotificationIconUrl, platform_data.icon.spec()); 52 EXPECT_EQ(kNotificationIconUrl, platform_data.icon.spec());
47 EXPECT_TRUE(platform_data.silent); 53 EXPECT_TRUE(platform_data.silent);
48 54
55 ASSERT_EQ(vibrate_pattern.size(), platform_data.vibrate.size());
56 for (size_t i = 0; i < vibrate_pattern.size(); ++i)
57 EXPECT_EQ(vibrate_pattern[i], platform_data.vibrate[i]);
58
49 ASSERT_EQ(developer_data.size(), platform_data.data.size()); 59 ASSERT_EQ(developer_data.size(), platform_data.data.size());
50 for (size_t i = 0; i < developer_data.size(); ++i) 60 for (size_t i = 0; i < developer_data.size(); ++i)
51 EXPECT_EQ(developer_data[i], platform_data.data[i]); 61 EXPECT_EQ(developer_data[i], platform_data.data[i]);
52 } 62 }
53 63
54 TEST(NotificationDataConversionsTest, 64 TEST(NotificationDataConversionsTest,
55 ToPlatformNotificationDataDirectionality) { 65 ToPlatformNotificationDataDirectionality) {
56 blink::WebNotificationData web_data; 66 blink::WebNotificationData web_data;
57 web_data.direction = blink::WebNotificationData::DirectionLeftToRight; 67 web_data.direction = blink::WebNotificationData::DirectionLeftToRight;
58 68
59 PlatformNotificationData platform_data = ToPlatformNotificationData(web_data); 69 PlatformNotificationData platform_data = ToPlatformNotificationData(web_data);
60 EXPECT_EQ(PlatformNotificationData::NotificationDirectionLeftToRight, 70 EXPECT_EQ(PlatformNotificationData::NotificationDirectionLeftToRight,
61 platform_data.direction); 71 platform_data.direction);
62 72
63 web_data.direction = blink::WebNotificationData::DirectionRightToLeft; 73 web_data.direction = blink::WebNotificationData::DirectionRightToLeft;
64 74
65 platform_data = ToPlatformNotificationData(web_data); 75 platform_data = ToPlatformNotificationData(web_data);
66 EXPECT_EQ(PlatformNotificationData::NotificationDirectionRightToLeft, 76 EXPECT_EQ(PlatformNotificationData::NotificationDirectionRightToLeft,
67 platform_data.direction); 77 platform_data.direction);
68 } 78 }
69 79
70 TEST(NotificationDataConversionsTest, ToWebNotificationData) { 80 TEST(NotificationDataConversionsTest, ToWebNotificationData) {
81 std::vector<unsigned> vibrate_pattern(
82 kNotificationVibrate,
83 kNotificationVibrate + arraysize(kNotificationVibrate));
84
71 std::vector<char> developer_data( 85 std::vector<char> developer_data(
72 kNotificationData, kNotificationData + arraysize(kNotificationData)); 86 kNotificationData, kNotificationData + arraysize(kNotificationData));
73 87
74 PlatformNotificationData platform_data; 88 PlatformNotificationData platform_data;
75 platform_data.title = base::ASCIIToUTF16(kNotificationTitle); 89 platform_data.title = base::ASCIIToUTF16(kNotificationTitle);
76 platform_data.direction = 90 platform_data.direction =
77 PlatformNotificationData::NotificationDirectionLeftToRight; 91 PlatformNotificationData::NotificationDirectionLeftToRight;
78 platform_data.lang = kNotificationLang; 92 platform_data.lang = kNotificationLang;
79 platform_data.body = base::ASCIIToUTF16(kNotificationBody); 93 platform_data.body = base::ASCIIToUTF16(kNotificationBody);
80 platform_data.tag = kNotificationTag; 94 platform_data.tag = kNotificationTag;
81 platform_data.icon = GURL(kNotificationIconUrl); 95 platform_data.icon = GURL(kNotificationIconUrl);
96 platform_data.vibrate = vibrate_pattern;
82 platform_data.silent = true; 97 platform_data.silent = true;
83 platform_data.data = developer_data; 98 platform_data.data = developer_data;
84 99
85 blink::WebNotificationData web_data = ToWebNotificationData(platform_data); 100 blink::WebNotificationData web_data = ToWebNotificationData(platform_data);
86 EXPECT_EQ(kNotificationTitle, web_data.title); 101 EXPECT_EQ(kNotificationTitle, web_data.title);
87 EXPECT_EQ(blink::WebNotificationData::DirectionLeftToRight, 102 EXPECT_EQ(blink::WebNotificationData::DirectionLeftToRight,
88 web_data.direction); 103 web_data.direction);
89 EXPECT_EQ(kNotificationLang, web_data.lang); 104 EXPECT_EQ(kNotificationLang, web_data.lang);
90 EXPECT_EQ(kNotificationBody, web_data.body); 105 EXPECT_EQ(kNotificationBody, web_data.body);
91 EXPECT_EQ(kNotificationTag, web_data.tag); 106 EXPECT_EQ(kNotificationTag, web_data.tag);
92 EXPECT_EQ(kNotificationIconUrl, web_data.icon.string()); 107 EXPECT_EQ(kNotificationIconUrl, web_data.icon.string());
108
109 ASSERT_EQ(vibrate_pattern.size(), web_data.vibrate.size());
110 for (size_t i = 0; i < vibrate_pattern.size(); ++i)
111 EXPECT_EQ(vibrate_pattern[i], web_data.vibrate[i]);
112
93 EXPECT_TRUE(web_data.silent); 113 EXPECT_TRUE(web_data.silent);
94 114
95 ASSERT_EQ(developer_data.size(), web_data.data.size()); 115 ASSERT_EQ(developer_data.size(), web_data.data.size());
96 for (size_t i = 0; i < developer_data.size(); ++i) 116 for (size_t i = 0; i < developer_data.size(); ++i)
97 EXPECT_EQ(developer_data[i], web_data.data[i]); 117 EXPECT_EQ(developer_data[i], web_data.data[i]);
98 } 118 }
99 119
100 TEST(NotificationDataConversionsTest, ToWebNotificationDataDirectionality) { 120 TEST(NotificationDataConversionsTest, ToWebNotificationDataDirectionality) {
101 PlatformNotificationData platform_data; 121 PlatformNotificationData platform_data;
102 platform_data.direction = 122 platform_data.direction =
103 PlatformNotificationData::NotificationDirectionLeftToRight; 123 PlatformNotificationData::NotificationDirectionLeftToRight;
104 124
105 blink::WebNotificationData web_data = ToWebNotificationData(platform_data); 125 blink::WebNotificationData web_data = ToWebNotificationData(platform_data);
106 EXPECT_EQ(blink::WebNotificationData::DirectionLeftToRight, 126 EXPECT_EQ(blink::WebNotificationData::DirectionLeftToRight,
107 web_data.direction); 127 web_data.direction);
108 128
109 platform_data.direction = 129 platform_data.direction =
110 PlatformNotificationData::NotificationDirectionRightToLeft; 130 PlatformNotificationData::NotificationDirectionRightToLeft;
111 131
112 web_data = ToWebNotificationData(platform_data); 132 web_data = ToWebNotificationData(platform_data);
113 EXPECT_EQ(blink::WebNotificationData::DirectionRightToLeft, 133 EXPECT_EQ(blink::WebNotificationData::DirectionRightToLeft,
114 web_data.direction); 134 web_data.direction);
115 } 135 }
116 136
117 } // namespace content 137 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698