Implement support for notification.vibrate

content/browser/notifications/notification_database_data_conversions.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/notifications/notification_database_data_conversions.h"
 
 #include "base/logging.h"
 #include "base/strings/utf_string_conversions.h"
 #include "content/browser/notifications/notification_database_data.pb.h"
 #include "content/public/browser/notification_database_data.h"
@@ skipping 20 matching lines @@
   notification_data->title = base::UTF8ToUTF16(payload.title());
   notification_data->direction =
       payload.direction() ==
           NotificationDatabaseDataProto::NotificationData::RIGHT_TO_LEFT ?
               PlatformNotificationData::NotificationDirectionRightToLeft :
               PlatformNotificationData::NotificationDirectionLeftToRight;
   notification_data->lang = payload.lang();
   notification_data->body = base::UTF8ToUTF16(payload.body());
   notification_data->tag = payload.tag();
   notification_data->icon = GURL(payload.icon());
+
+  for (int i = 0; i < payload.vibrate_size(); ++i)

[Peter Beverloo, 2015/04/21 17:58:23]

google::protobuf::RepeatedField exposes iterators which can do this for us,
rather than iterating manually. Perhaps you'd prefer this?

if (payload.vibrate_size()) {
  notification_data->vibrate.assign(payload.vibrate().begin(),
                                    payload.vibrate().end());
}

[Sanghyun Park, 2015/04/23 11:08:26]

I'd like to use iterators too :)
I'll modify this.

+    notification_data->vibrate.push_back(payload.vibrate(i));
+
   notification_data->silent = payload.silent();
 
   if (payload.data().length()) {
     notification_data->data.assign(payload.data().begin(),
                                    payload.data().end());
   }
 
   return true;
 }
 
 bool SerializeNotificationDatabaseData(const NotificationDatabaseData& input,
                                        std::string* output) {
   DCHECK(output);
 
   scoped_ptr<NotificationDatabaseDataProto::NotificationData> payload(
       new NotificationDatabaseDataProto::NotificationData());
 
   const PlatformNotificationData& notification_data = input.notification_data;
 
   payload->set_title(base::UTF16ToUTF8(notification_data.title));
   payload->set_direction(
       notification_data.direction ==
           PlatformNotificationData::NotificationDirectionRightToLeft ?
               NotificationDatabaseDataProto::NotificationData::RIGHT_TO_LEFT :
               NotificationDatabaseDataProto::NotificationData::LEFT_TO_RIGHT);
   payload->set_lang(notification_data.lang);
   payload->set_body(base::UTF16ToUTF8(notification_data.body));
   payload->set_tag(notification_data.tag);
   payload->set_icon(notification_data.icon.spec());
+
+  for (size_t i = 0; i < notification_data.vibrate.size(); ++i)
+    payload->add_vibrate(notification_data.vibrate[i]);
+
   payload->set_silent(notification_data.silent);
 
   if (notification_data.data.size()) {
     payload->set_data(&notification_data.data.front(),
                       notification_data.data.size());
   }
 
   NotificationDatabaseDataProto message;
   message.set_notification_id(input.notification_id);
   message.set_origin(input.origin.spec());
   message.set_service_worker_registration_id(
       input.service_worker_registration_id);
   message.set_allocated_notification_data(payload.release());
 
   return message.SerializeToString(output);
 }
 
 }  // namespace content