Implement support for notification.vibrate

content/browser/notifications/notification_database_data_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/strings/utf_string_conversions.h"
 #include "content/browser/notifications/notification_database_data.pb.h"
 #include "content/browser/notifications/notification_database_data_conversions.h"
 #include "content/public/browser/notification_database_data.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace content {
 
 const int64_t kNotificationId = 42;
 const int64_t kServiceWorkerRegistrationId = 9001;
 
 const char kOrigin[] = "https://example.com/";
 const char kNotificationTitle[] = "My Notification";
 const char kNotificationLang[] = "nl";
 const char kNotificationBody[] = "Hello, world!";
 const char kNotificationTag[] = "my_tag";
 const char kNotificationIconUrl[] = "https://example.com/icon.png";
+const int kNotificationVibrationPattern[] = { 100, 200, 300 };
 const unsigned char kNotificationData[] = { 0xdf, 0xff, 0x0, 0x0, 0xff, 0xdf };
 
 TEST(NotificationDatabaseDataTest, SerializeAndDeserializeData) {
+  std::vector<int> vibration_pattern(
+      kNotificationVibrationPattern,
+      kNotificationVibrationPattern + arraysize(kNotificationVibrationPattern));
+
   std::vector<char> developer_data(
       kNotificationData, kNotificationData + arraysize(kNotificationData));
 
   PlatformNotificationData notification_data;
   notification_data.title = base::ASCIIToUTF16(kNotificationTitle);
   notification_data.direction =
       PlatformNotificationData::NotificationDirectionRightToLeft;
   notification_data.lang = kNotificationLang;
   notification_data.body = base::ASCIIToUTF16(kNotificationBody);
   notification_data.tag = kNotificationTag;
   notification_data.icon = GURL(kNotificationIconUrl);
+  notification_data.vibration_pattern = vibration_pattern;
   notification_data.silent = true;
   notification_data.data = developer_data;
 
   NotificationDatabaseData database_data;
   database_data.notification_id = kNotificationId;
   database_data.origin = GURL(kOrigin);
   database_data.service_worker_registration_id = kServiceWorkerRegistrationId;
   database_data.notification_data = notification_data;
 
   std::string serialized_data;
@@ skipping 15 matching lines @@
 
   const PlatformNotificationData& copied_notification_data =
       copied_data.notification_data;
 
   EXPECT_EQ(notification_data.title, copied_notification_data.title);
   EXPECT_EQ(notification_data.direction, copied_notification_data.direction);
   EXPECT_EQ(notification_data.lang, copied_notification_data.lang);
   EXPECT_EQ(notification_data.body, copied_notification_data.body);
   EXPECT_EQ(notification_data.tag, copied_notification_data.tag);
   EXPECT_EQ(notification_data.icon, copied_notification_data.icon);
+
+  ASSERT_EQ(vibration_pattern.size(),

[dcheng, 2015/05/06 18:43:27]

You could do something like:
EXPECT_THAT(copied_notification_data.vibration_patterns,
ElementsAre(kNotificationVibrationPattern));

I don't feel strongly about this, but it might be slightly easier to write.

[Sanghyun Park, 2015/05/07 12:08:33]

Your suggestion is better than this code. :)
I'll change this

+            copied_notification_data.vibration_pattern.size());
+  for (size_t i = 0; i < vibration_pattern.size(); ++i) {
+    EXPECT_EQ(vibration_pattern[i],
+              copied_notification_data.vibration_pattern[i]);
+  }
+
   EXPECT_EQ(notification_data.silent, copied_notification_data.silent);
 
   ASSERT_EQ(developer_data.size(), copied_notification_data.data.size());
   for (size_t i = 0; i < developer_data.size(); ++i)
     EXPECT_EQ(developer_data[i], copied_notification_data.data[i]);
 }
 
 }  // namespace content