gin::Wrappable shouldn't inherit from base::RefCounted

gin::Wrappable shouldn't inherit from base::RefCounted

Rather than using reference counting to keep gin::Wrappable objects alive, we
use the V8 garbage collector. To retain a reference to a wrappable object on
the stack, use a gin::Handle. Currently there is no mechanism for retaining a
gin::Wrappable object in the heap, but we'll likely add one in the future.

R=aa@chromium.org
BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238902

[abarth-chromium, 2013-12-04 21:33:08]

https://codereview.chromium.org/105423003/diff/1/gin/function_template.h
File gin/function_template.h (right):

https://codereview.chromium.org/105423003/diff/1/gin/function_template.h#newc...
gin/function_template.h:348: isolate,
Not sure where this part of the diff is coming from.  Maybe the pump file is out
of date?

[Aaron Boodman, 2013-12-04 22:04:42]

lgtm

https://codereview.chromium.org/105423003/diff/1/gin/function_template.h
File gin/function_template.h (right):

https://codereview.chromium.org/105423003/diff/1/gin/function_template.h#newc...
gin/function_template.h:348: isolate,
On 2013/12/04 21:33:08, abarth wrote:
> Not sure where this part of the diff is coming from.  Maybe the pump file is
out
> of date?

Hm. Perhaps.

https://codereview.chromium.org/105423003/diff/1/gin/handle.h
File gin/handle.h (right):

https://codereview.chromium.org/105423003/diff/1/gin/handle.h#newcode19
gin/handle.h:19: Handle() : object_(0) {}
NULL

https://codereview.chromium.org/105423003/diff/1/gin/handle.h#newcode35
gin/handle.h:35: T* Get() const { return object_; }
Since this is a trivial getter, it should be lower-case per Chromium style.

https://codereview.chromium.org/105423003/diff/1/gin/handle.h#newcode45
gin/handle.h:45: gin::Handle<T> val) {
Since gin::Handle is two pointers, it really is cheaper to pass it by const ref
:).

[abarth-chromium, 2013-12-04 22:24:11]

https://codereview.chromium.org/105423003/diff/1/gin/handle.h
File gin/handle.h (right):

https://codereview.chromium.org/105423003/diff/1/gin/handle.h#newcode19
gin/handle.h:19: Handle() : object_(0) {}
On 2013/12/04 22:04:42, Aaron Boodman wrote:
> NULL

Done.

https://codereview.chromium.org/105423003/diff/1/gin/handle.h#newcode35
gin/handle.h:35: T* Get() const { return object_; }
On 2013/12/04 22:04:42, Aaron Boodman wrote:
> Since this is a trivial getter, it should be lower-case per Chromium style.

Done.

https://codereview.chromium.org/105423003/diff/1/gin/handle.h#newcode45
gin/handle.h:45: gin::Handle<T> val) {
On 2013/12/04 22:04:42, Aaron Boodman wrote:
> Since gin::Handle is two pointers, it really is cheaper to pass it by const
ref
> :).

Done.

[commit-bot: I haz the power, 2013-12-04 22:29:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/105423003/20001

[commit-bot: I haz the power, 2013-12-05 00:06:56]

Retried try job too often on win_rel for step(s) app_list_unittests,
ash_unittests, aura_unittests, base_unittests, browser_tests,
cacheinvalidation_unittests, cc_unittests, check_deps, chromedriver2_unittests,
components_unittests, compositor_unittests, content_browsertests,
content_unittests, crypto_unittests, events_unittests, gpu_unittests,
installer_util_unittests, interactive_ui_tests, ipc_tests, jingle_unittests,
media_unittests, mini_installer_test, net_unittests, ppapi_unittests,
printing_unittests, remoting_unittests, sql_unittests, sync_integration_tests,
sync_unit_tests, telemetry_unittests, unit_tests, views_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-12-05 03:06:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/105423003/20001

[commit-bot: I haz the power, 2013-12-05 03:57:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/105423003/40001

[commit-bot: I haz the power, 2013-12-05 04:10:33]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[commit-bot: I haz the power, 2013-12-05 04:42:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/105423003/40001

[abarth-chromium, 2013-12-05 05:48:17]

Committed patchset #3 manually as r238902 (presubmit successful).