Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(836)

Unified Diff: mojo/apps/js/bindings/waiting_callback.h

Issue 105423003: gin::Wrappable shouldn't inherit from base::RefCounted (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix win Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/apps/js/bindings/support.cc ('k') | mojo/apps/js/bindings/waiting_callback.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/apps/js/bindings/waiting_callback.h
diff --git a/mojo/apps/js/bindings/waiting_callback.h b/mojo/apps/js/bindings/waiting_callback.h
index 2e1653db5030c917d152f0bbcf93993eed6d68bd..9036c4e248607a556ae6760b0b49a5f94c65585f 100644
--- a/mojo/apps/js/bindings/waiting_callback.h
+++ b/mojo/apps/js/bindings/waiting_callback.h
@@ -5,6 +5,7 @@
#ifndef MOJO_APPS_JS_BINDINGS_WAITING_CALLBACK_H_
#define MOJO_APPS_JS_BINDINGS_WAITING_CALLBACK_H_
+#include "gin/handle.h"
#include "gin/runner.h"
#include "gin/wrappable.h"
#include "mojo/public/bindings/lib/bindings_support.h"
@@ -15,7 +16,7 @@ namespace js {
class WaitingCallback : public gin::Wrappable,
public BindingsSupport::AsyncWaitCallback {
public:
- static scoped_refptr<WaitingCallback> Create(
+ static gin::Handle<WaitingCallback> Create(
v8::Isolate* isolate, v8::Handle<v8::Function> callback);
static gin::WrapperInfo kWrapperInfo;
« no previous file with comments | « mojo/apps/js/bindings/support.cc ('k') | mojo/apps/js/bindings/waiting_callback.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698