mojo/apps/js/bindings/support.cc - Issue 105423003: gin::Wrappable shouldn't inherit from base::RefCounted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/apps/js/bindings/support.cc

Issue 105423003: gin::Wrappable shouldn't inherit from base::RefCounted (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix win Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/apps/js/bindings/support.cc

diff --git a/mojo/apps/js/bindings/support.cc b/mojo/apps/js/bindings/support.cc

index e07cc093721956c19ff764db56074458751d0db2..2e627bdeed1b80f572f9fc7e6244bb6b80d8d4ae 100644

--- a/mojo/apps/js/bindings/support.cc

+++ b/mojo/apps/js/bindings/support.cc

@@ -24,7 +24,7 @@ namespace {

WaitingCallback* AsyncWait(const gin::Arguments& args, mojo::Handle handle,

MojoWaitFlags flags,

v8::Handle<v8::Function> callback) {

- scoped_refptr<WaitingCallback> waiting_callback =

+ gin::Handle<WaitingCallback> waiting_callback =

WaitingCallback::Create(args.isolate(), callback);

BindingsSupport::AsyncWaitID wait_id = BindingsSupport::Get()->AsyncWait(

« no previous file with comments | « gin/wrappable_unittest.cc ('k') | mojo/apps/js/bindings/waiting_callback.h » ('j') | no next file with comments »