Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1295)

Unified Diff: mojo/apps/js/bindings/waiting_callback.cc

Issue 105423003: gin::Wrappable shouldn't inherit from base::RefCounted (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix win Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/apps/js/bindings/waiting_callback.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/apps/js/bindings/waiting_callback.cc
diff --git a/mojo/apps/js/bindings/waiting_callback.cc b/mojo/apps/js/bindings/waiting_callback.cc
index 2832685318c973359ec799d6b7de0b30eaeac883..a1d230c174b0e0c0b03b36b66457c154fa7ec5fe 100644
--- a/mojo/apps/js/bindings/waiting_callback.cc
+++ b/mojo/apps/js/bindings/waiting_callback.cc
@@ -30,9 +30,9 @@ WaitingCallback::~WaitingCallback() {
DCHECK(!wait_id_) << "Waiting callback was destroyed before being cancelled.";
}
-scoped_refptr<WaitingCallback> WaitingCallback::Create(
+gin::Handle<WaitingCallback> WaitingCallback::Create(
v8::Isolate* isolate, v8::Handle<v8::Function> callback) {
- return make_scoped_refptr(new WaitingCallback(isolate, callback));
+ return gin::CreateHandle(isolate, new WaitingCallback(isolate, callback));
}
gin::WrapperInfo WaitingCallback::kWrapperInfo = { gin::kEmbedderNativeGin };
« no previous file with comments | « mojo/apps/js/bindings/waiting_callback.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698