Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: mojo/apps/js/bindings/waiting_callback.h

Issue 105423003: gin::Wrappable shouldn't inherit from base::RefCounted (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix win Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « mojo/apps/js/bindings/support.cc ('k') | mojo/apps/js/bindings/waiting_callback.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MOJO_APPS_JS_BINDINGS_WAITING_CALLBACK_H_ 5 #ifndef MOJO_APPS_JS_BINDINGS_WAITING_CALLBACK_H_
6 #define MOJO_APPS_JS_BINDINGS_WAITING_CALLBACK_H_ 6 #define MOJO_APPS_JS_BINDINGS_WAITING_CALLBACK_H_
7 7
8 #include "gin/handle.h"
8 #include "gin/runner.h" 9 #include "gin/runner.h"
9 #include "gin/wrappable.h" 10 #include "gin/wrappable.h"
10 #include "mojo/public/bindings/lib/bindings_support.h" 11 #include "mojo/public/bindings/lib/bindings_support.h"
11 12
12 namespace mojo { 13 namespace mojo {
13 namespace js { 14 namespace js {
14 15
15 class WaitingCallback : public gin::Wrappable, 16 class WaitingCallback : public gin::Wrappable,
16 public BindingsSupport::AsyncWaitCallback { 17 public BindingsSupport::AsyncWaitCallback {
17 public: 18 public:
18 static scoped_refptr<WaitingCallback> Create( 19 static gin::Handle<WaitingCallback> Create(
19 v8::Isolate* isolate, v8::Handle<v8::Function> callback); 20 v8::Isolate* isolate, v8::Handle<v8::Function> callback);
20 21
21 static gin::WrapperInfo kWrapperInfo; 22 static gin::WrapperInfo kWrapperInfo;
22 virtual gin::WrapperInfo* GetWrapperInfo() OVERRIDE; 23 virtual gin::WrapperInfo* GetWrapperInfo() OVERRIDE;
23 static void EnsureRegistered(v8::Isolate* isolate); 24 static void EnsureRegistered(v8::Isolate* isolate);
24 25
25 BindingsSupport::AsyncWaitID wait_id() const { 26 BindingsSupport::AsyncWaitID wait_id() const {
26 return wait_id_; 27 return wait_id_;
27 } 28 }
28 29
(...skipping 18 matching lines...) Expand all
47 48
48 namespace gin { 49 namespace gin {
49 50
50 template<> 51 template<>
51 struct Converter<mojo::js::WaitingCallback*> 52 struct Converter<mojo::js::WaitingCallback*>
52 : public WrappableConverter<mojo::js::WaitingCallback> {}; 53 : public WrappableConverter<mojo::js::WaitingCallback> {};
53 54
54 } // namespace gin 55 } // namespace gin
55 56
56 #endif // MOJO_APPS_JS_BINDINGS_WAITING_CALLBACK_H_ 57 #endif // MOJO_APPS_JS_BINDINGS_WAITING_CALLBACK_H_
OLDNEW
« no previous file with comments | « mojo/apps/js/bindings/support.cc ('k') | mojo/apps/js/bindings/waiting_callback.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698