Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1044923003: Add the WebHistoryCommitType to didFailProvisionalLoad, part 3. (Closed)

Created:
5 years, 8 months ago by Avi (use Gerrit)
Modified:
5 years, 8 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@committype1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add the WebHistoryCommitType to didFailProvisionalLoad, part 3. BUG=471292 TEST=none Committed: https://crrev.com/31b6fa4397bc79a5a4b3b9e3805176a28a05fdda Cr-Commit-Position: refs/heads/master@{#323049}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -37 lines) Patch
M content/renderer/render_frame_impl.h View 2 chunks +0 lines, -5 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 4 chunks +6 lines, -16 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 1 5 chunks +9 lines, -4 lines 0 comments Download
M content/shell/renderer/test_runner/web_frame_test_proxy.h View 1 2 chunks +10 lines, -7 lines 0 comments Download
M content/shell/renderer/test_runner/web_test_proxy.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/web_test_proxy.cc View 1 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Avi (use Gerrit)
Charlie, Nate— This is the third in the series. https://codereview.chromium.org/1033233003 https://codereview.chromium.org/1046953003 https://codereview.chromium.org/1044923003
5 years, 8 months ago (2015-03-30 18:53:32 UTC) #2
Charlie Reis
LGTM
5 years, 8 months ago (2015-03-30 21:27:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1044923003/20001
5 years, 8 months ago (2015-03-31 15:09:29 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-03-31 16:09:19 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-03-31 16:09:54 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/31b6fa4397bc79a5a4b3b9e3805176a28a05fdda
Cr-Commit-Position: refs/heads/master@{#323049}

Powered by Google App Engine
This is Rietveld 408576698