Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1033233003: Add the WebHistoryCommitType to didFailProvisionalLoad, part 1. (Closed)

Created:
5 years, 8 months ago by Avi (use Gerrit)
Modified:
5 years, 8 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add the WebHistoryCommitType to didFailProvisionalLoad, part 1. BUG=471292 TEST=none Committed: https://crrev.com/be2d51d42fe8a377f084d92012c115a3478fe5d4 Cr-Commit-Position: refs/heads/master@{#322923}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M content/renderer/render_frame_impl.h View 2 chunks +7 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Avi (use Gerrit)
Charlie, Nate— This is the first in the series. https://codereview.chromium.org/1033233003 https://codereview.chromium.org/1046953003 https://codereview.chromium.org/1044923003
5 years, 8 months ago (2015-03-30 18:53:00 UTC) #2
Charlie Reis
LGTM
5 years, 8 months ago (2015-03-30 21:25:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1033233003/1
5 years, 8 months ago (2015-03-31 00:16:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-03-31 00:21:33 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-03-31 00:22:28 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/be2d51d42fe8a377f084d92012c115a3478fe5d4
Cr-Commit-Position: refs/heads/master@{#322923}

Powered by Google App Engine
This is Rietveld 408576698