content/renderer/render_frame_impl.h - Issue 1044923003: Add the WebHistoryCommitType to didFailProvisionalLoad, part 3.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.h

Issue 1044923003: Add the WebHistoryCommitType to didFailProvisionalLoad, part 3. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@committype1

Patch Set: fix Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/render_frame_impl.h

diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h

index 8fce8604b48e8c386ef3d44694bef596d50e202c..c1bd46be9a9b5ff7db36cec6797b26f43c3fdb1e 100644

--- a/content/renderer/render_frame_impl.h

+++ b/content/renderer/render_frame_impl.h

@@ -403,9 +403,6 @@ class CONTENT_EXPORT RenderFrameImpl

blink::WebLocalFrame* frame);

virtual void didFailProvisionalLoad(

blink::WebLocalFrame* frame,

- const blink::WebURLError& error);

- virtual void didFailProvisionalLoad(

- blink::WebLocalFrame* frame,

const blink::WebURLError& error,

blink::WebHistoryCommitType commit_type);

virtual void didCommitProvisionalLoad(

@@ -423,8 +420,6 @@ class CONTENT_EXPORT RenderFrameImpl

virtual void didFinishDocumentLoad(blink::WebLocalFrame* frame);

virtual void didHandleOnloadEvents(blink::WebLocalFrame* frame);

virtual void didFailLoad(blink::WebLocalFrame* frame,

- const blink::WebURLError& error);

- virtual void didFailLoad(blink::WebLocalFrame* frame,

const blink::WebURLError& error,

blink::WebHistoryCommitType commit_type);

virtual void didFinishLoad(blink::WebLocalFrame* frame);

« no previous file with comments | « no previous file | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »