content/shell/renderer/test_runner/web_test_proxy.h - Issue 1044923003: Add the WebHistoryCommitType to didFailProvisionalLoad, part 3.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/renderer/test_runner/web_test_proxy.h

Issue 1044923003: Add the WebHistoryCommitType to didFailProvisionalLoad, part 3. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@committype1

Patch Set: fix Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/renderer/test_runner/web_frame_test_proxy.h ('k') | content/shell/renderer/test_runner/web_test_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/renderer/test_runner/web_test_proxy.h

diff --git a/content/shell/renderer/test_runner/web_test_proxy.h b/content/shell/renderer/test_runner/web_test_proxy.h

index 88dd814c2e0ef9a40ac24d1f828dadec119d5f32..d170c95d219994cb269bf22286212d72619ae2f8 100644

--- a/content/shell/renderer/test_runner/web_test_proxy.h

+++ b/content/shell/renderer/test_runner/web_test_proxy.h

@@ -187,7 +187,8 @@ class WebTestProxyBase {

void DidStartProvisionalLoad(blink::WebLocalFrame*);

void DidReceiveServerRedirectForProvisionalLoad(blink::WebLocalFrame* frame);

bool DidFailProvisionalLoad(blink::WebLocalFrame* frame,

- const blink::WebURLError& error);

+ const blink::WebURLError& error,

+ blink::WebHistoryCommitType commit_type);

void DidCommitProvisionalLoad(blink::WebLocalFrame* frame,

const blink::WebHistoryItem& history_item,

blink::WebHistoryCommitType history_type);

@@ -199,7 +200,8 @@ class WebTestProxyBase {

void DidFinishDocumentLoad(blink::WebLocalFrame* frame);

void DidHandleOnloadEvents(blink::WebLocalFrame* frame);

void DidFailLoad(blink::WebLocalFrame* frame,

- const blink::WebURLError& error);

+ const blink::WebURLError& error,

+ blink::WebHistoryCommitType commit_type);

void DidFinishLoad(blink::WebLocalFrame* frame);

void DidChangeLocationWithinPage(blink::WebLocalFrame* frame);

void DidDetectXSS(blink::WebLocalFrame* frame,

« no previous file with comments | « content/shell/renderer/test_runner/web_frame_test_proxy.h ('k') | content/shell/renderer/test_runner/web_test_proxy.cc » ('j') | no next file with comments »