Lint bisect-related modules; obey pylint.

Lint bisect-related modules; obey pylint.

This style should only contain style changes, no real refactoring or functional changes.

BUG=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294682

[qyearsley, 2015-03-27 23:44:29]

qyearsley@chromium.org changed reviewers:
+ robertocn@chromium.org

[RobertoCN, 2015-03-31 21:34:57]

LGTM

Thank you very much for this!

[RobertoCN, 2015-03-31 21:35:20]

robertocn@chromium.org changed reviewers:
+ prasadv@chromium.org

[prasadv1, 2015-03-31 21:43:12]

prasadv@google.com changed reviewers:
+ prasadv@google.com

[prasadv1, 2015-03-31 21:43:12]

lgtm

[RobertoCN, 2015-03-31 21:43:43]

The CQ bit was checked by robertocn@chromium.org

[commit-bot: I haz the power, 2015-03-31 21:44:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1044543002/20001

[commit-bot: I haz the power, 2015-03-31 21:48:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-31 21:48:11]

Presubmit check for 1044543002-20001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    build/scripts/slave/recipes/bisect.py

Presubmit checks took 234.0s to calculate.

[qyearsley, 2015-03-31 22:05:37]

qyearsley@chromium.org changed reviewers:
+ iannucci@chromium.org

[qyearsley, 2015-04-02 04:13:39]

Robbie, this CL is waiting on an LGTM from you (or Aaron), unless Roberto or
Prasad get made per-file owners of recipes/bisect.py
(https://codereview.chromium.org/1049833002/).

[iannucci, 2015-04-03 20:56:13]

lgtm

[qyearsley, 2015-04-03 21:11:52]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2015-04-03 21:12:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1044543002/20001

[commit-bot: I haz the power, 2015-04-03 21:12:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-03 21:12:12]

Failed to apply patch for
build/scripts/slave/recipe_modules/auto_bisect/bisect_results.py:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file build/scripts/slave/recipe_modules/auto_bisect/bisect_results.py
  Hunk #1 succeeded at 99 with fuzz 2 (offset 95 lines).
  Hunk #2 FAILED at 37.
  Hunk #3 FAILED at 53.
  2 out of 3 hunks FAILED -- saving rejects to file
build/scripts/slave/recipe_modules/auto_bisect/bisect_results.py.rej

Patch:       build/scripts/slave/recipe_modules/auto_bisect/bisect_results.py
Index: scripts/slave/recipe_modules/auto_bisect/bisect_results.py
diff --git build/scripts/slave/recipe_modules/auto_bisect/bisect_results.py
build/scripts/slave/recipe_modules/auto_bisect/bisect_results.py
index
19b4c65b79e6ebb429892984b774173125e9cb1f..83ebf576cba72ac96bfef7f77e9a23f0d5b8618b
100644
--- a/build/scripts/slave/recipe_modules/auto_bisect/bisect_results.py
+++ b/build/scripts/slave/recipe_modules/auto_bisect/bisect_results.py
@@ -4,6 +4,7 @@
 
 import json
 
+
 class BisectResults(object):
   def __init__(self, bisector):
     """Create a new results object from a finished bisect job."""
@@ -36,8 +37,8 @@ class BisectResults(object):
       self._results_dict['warnings'] = list(
           self._bisector.warnings)  # pragma: no cover
 
-    self._= '\n'.join(['%s: %s' % (k, v) for k, v in
-                       self._bisector.bad_rev.test_info().iteritems()])
+    self._ = '\n'.join('%s: %s' % (k, v) for k, v in
+                       self._bisector.bad_rev.test_info().iteritems())
     # TODO: Add the culprit CL details if available
     self._compose_revisions_list()
 
@@ -52,5 +53,3 @@ class BisectResults(object):
                                              else 'untested'),
         'culprit': self._bisector.culprit == r
     } for r in self._bisector.revisions]
-
-

[qyearsley, 2015-04-03 21:58:01]

Hey, I just rebased, resolved conflicts and uploaded a new patch; Roberto, could
you double-check that it's still correct?

[RobertoCN, 2015-04-03 22:06:13]

On 2015/04/03 21:58:01, qyearsley wrote:
> Hey, I just rebased, resolved conflicts and uploaded a new patch; Roberto,
could
> you double-check that it's still correct?

It still LGTM.

[qyearsley, 2015-04-03 22:37:40]

The CQ bit was checked by qyearsley@chromium.org

[qyearsley, 2015-04-03 22:37:41]

The patchset sent to the CQ was uploaded after l-g-t-m from prasadv@google.com,
iannucci@chromium.org
Link to the patchset: https://codereview.chromium.org/1044543002/#ps40001
(title: "Rebased")

[commit-bot: I haz the power, 2015-04-03 22:37:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1044543002/40001

[commit-bot: I haz the power, 2015-04-03 22:42:24]

Committed patchset #3 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294682