Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Unified Diff: scripts/slave/recipe_modules/auto_bisect/bisector_test.py

Issue 1044543002: Lint bisect-related modules; obey pylint. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Rebased Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/auto_bisect/bisector_test.py
diff --git a/scripts/slave/recipe_modules/auto_bisect/bisector_test.py b/scripts/slave/recipe_modules/auto_bisect/bisector_test.py
index dcc20a3145b2cbc045148012947bda0f7c8a0443..26889b6f54d061c4512a5ffc02882d15348040ca 100644
--- a/scripts/slave/recipe_modules/auto_bisect/bisector_test.py
+++ b/scripts/slave/recipe_modules/auto_bisect/bisector_test.py
@@ -21,6 +21,7 @@ from auto_bisect.bisector import Bisector
class MockRevisionClass(object): # pragma: no cover
+
def __init__(self, rev_string, bisector):
self.commit_pos = int(rev_string)
self.revision_string = rev_string
@@ -36,11 +37,12 @@ class MockRevisionClass(object): # pragma: no cover
class BisectorTest(unittest.TestCase): # pragma: no cover
+
def setUp(self):
self.bisect_config = {
'test_type': 'perf',
- 'command': 'tools/perf/run_benchmark -v '
- '--browser=release page_cycler.intl_ar_fa_he',
+ 'command': ('tools/perf/run_benchmark -v '
+ '--browser=release page_cycler.intl_ar_fa_he'),
'good_revision': '306475',
'bad_revision': '306478',
'metric': 'warm_times/page_load_time',
@@ -55,8 +57,6 @@ class BisectorTest(unittest.TestCase): # pragma: no cover
}
self.dummy_api = mock.Mock()
-
-
def test_create_bisector(self):
bisector = Bisector(self.dummy_api, self.bisect_config, MockRevisionClass)
# Check the proper revision range is initialized
« no previous file with comments | « scripts/slave/recipe_modules/auto_bisect/bisector.py ('k') | scripts/slave/recipe_modules/auto_bisect/revision_state.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698