Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Side by Side Diff: scripts/slave/recipe_modules/auto_bisect/bisector.py

Issue 1044543002: Lint bisect-related modules; obey pylint. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Rebased Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import re 5 import re
6 6
7 from . import bisect_results 7 from . import bisect_results
8 from . import depot_config 8 from . import depot_config
9 9
10 _DEPS_SHA_PATCH = """ 10 _DEPS_SHA_PATCH = """
(...skipping 335 matching lines...) Expand 10 before | Expand all | Expand 10 after
346 return True 346 return True
347 347
348 def get_exception(self): 348 def get_exception(self):
349 raise NotImplementedError() # pragma: no cover 349 raise NotImplementedError() # pragma: no cover
350 # TODO: should return an exception with the details of the failure. 350 # TODO: should return an exception with the details of the failure.
351 351
352 def _set_insufficient_confidence_warning( 352 def _set_insufficient_confidence_warning(
353 self, actual_confidence): # pragma: no cover 353 self, actual_confidence): # pragma: no cover
354 """Adds a warning about the lack of initial regression confidence.""" 354 """Adds a warning about the lack of initial regression confidence."""
355 self.failed_confidence = True 355 self.failed_confidence = True
356 self.warnings.append(('Bisect failed to reproduce the regression with ' 356 self.warnings.append(
357 'enough confidence. Needed {:.2f}%, got {:.2f}%.' 357 ('Bisect failed to reproduce the regression with enough confidence. '
358 ).format(self.required_regression_confidence, 358 'Needed {:.2f}%, got {:.2f}%.').format(
359 actual_confidence)) 359 self.required_regression_confidence, actual_confidence))
360 360
361 def _compute_results_confidence(self): 361 def _compute_results_confidence(self):
362 self.results_confidence = self.api.m.math_utils.confidence_score( 362 self.results_confidence = self.api.m.math_utils.confidence_score(
363 self.lkgr.values, self.fkbr.values) 363 self.lkgr.values, self.fkbr.values)
364 364
365 def print_result(self): 365 def print_result(self):
366 results = bisect_results.BisectResults(self).as_string() 366 results = bisect_results.BisectResults(self).as_string()
367 self.api.m.step('Results', ['cat'], 367 self.api.m.step('Results', ['cat'],
368 stdin=self.api.m.raw_io.input(data=results)) 368 stdin=self.api.m.raw_io.input(data=results))
369 369
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
480 # TODO: Actually check the current platform 480 # TODO: Actually check the current platform
481 return 'linux_perf_tester' 481 return 'linux_perf_tester'
482 482
483 def get_builder_bot_for_this_platform(self): 483 def get_builder_bot_for_this_platform(self):
484 # TODO: Actually look at the current platform. 484 # TODO: Actually look at the current platform.
485 return 'linux_perf_bisect_builder' 485 return 'linux_perf_bisect_builder'
486 486
487 def get_platform_gs_prefix(self): 487 def get_platform_gs_prefix(self):
488 # TODO: Actually check the current platform 488 # TODO: Actually check the current platform
489 return 'gs://chrome-perf/Linux Builder/full-build-linux_' 489 return 'gs://chrome-perf/Linux Builder/full-build-linux_'
490
OLDNEW
« no previous file with comments | « scripts/slave/recipe_modules/auto_bisect/bisect_results.py ('k') | scripts/slave/recipe_modules/auto_bisect/bisector_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698