Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Unified Diff: scripts/slave/recipe_modules/auto_bisect/bisector.py

Issue 1044543002: Lint bisect-related modules; obey pylint. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Rebased Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/auto_bisect/bisector.py
diff --git a/scripts/slave/recipe_modules/auto_bisect/bisector.py b/scripts/slave/recipe_modules/auto_bisect/bisector.py
index 922557f4a4017f32010349ffc193f7ad9eccabba..ab894f7b335d7804a51f611323eb7d96d202dea9 100644
--- a/scripts/slave/recipe_modules/auto_bisect/bisector.py
+++ b/scripts/slave/recipe_modules/auto_bisect/bisector.py
@@ -353,10 +353,10 @@ class Bisector(object):
self, actual_confidence): # pragma: no cover
"""Adds a warning about the lack of initial regression confidence."""
self.failed_confidence = True
- self.warnings.append(('Bisect failed to reproduce the regression with '
- 'enough confidence. Needed {:.2f}%, got {:.2f}%.'
- ).format(self.required_regression_confidence,
- actual_confidence))
+ self.warnings.append(
+ ('Bisect failed to reproduce the regression with enough confidence. '
+ 'Needed {:.2f}%, got {:.2f}%.').format(
+ self.required_regression_confidence, actual_confidence))
def _compute_results_confidence(self):
self.results_confidence = self.api.m.math_utils.confidence_score(
@@ -487,4 +487,3 @@ class Bisector(object):
def get_platform_gs_prefix(self):
# TODO: Actually check the current platform
return 'gs://chrome-perf/Linux Builder/full-build-linux_'
-
« no previous file with comments | « scripts/slave/recipe_modules/auto_bisect/bisect_results.py ('k') | scripts/slave/recipe_modules/auto_bisect/bisector_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698