Ignore autocomplete='off' for usernames and passwords.

Ignore autocomplete='off' for usernames and passwords. Because autofilling requires a user gesture/interaction to complete into the DOM, we can safely ignore autocomplete='off' on forms for passwords and usernames. This will greatly increase our password autofill coverage and allow users to generate and store random passwords more regularly.

BUG=177288
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238790

[jww, 2013-12-04 01:53:52]

We're still waiting for https://codereview.chromium.org/83023017/ to land, but I
believe this is ready for review.

[jww, 2013-12-04 05:27:47]

On 2013/12/04 01:53:52, jww wrote:
> We're still waiting for https://codereview.chromium.org/83023017/ to land, but
I
> believe this is ready for review.

https://codereview.chromium.org/83023017/ has landed, and I will rebase on top
of it as soon as it hits LKGR.

[jww, 2013-12-04 16:22:37]

I have rebased on ToT and it is now fully ready for review.

[Garrett Casto, 2013-12-04 18:32:16]

lgtm

https://codereview.chromium.org/103503002/diff/20001/chrome/renderer/autofill...
File chrome/renderer/autofill/password_autofill_agent_browsertest.cc (right):

https://codereview.chromium.org/103503002/diff/20001/chrome/renderer/autofill...
chrome/renderer/autofill/password_autofill_agent_browsertest.cc:485:
UTF16ToUTF8(username1_), true, UTF16ToUTF8(password1_), true);
Nit: Generally this file just checks against kAliceUsername so that you don't
have to do the conversion again.

[jww, 2013-12-04 20:00:56]

https://codereview.chromium.org/103503002/diff/20001/chrome/renderer/autofill...
File chrome/renderer/autofill/password_autofill_agent_browsertest.cc (right):

https://codereview.chromium.org/103503002/diff/20001/chrome/renderer/autofill...
chrome/renderer/autofill/password_autofill_agent_browsertest.cc:485:
UTF16ToUTF8(username1_), true, UTF16ToUTF8(password1_), true);
On 2013/12/04 18:32:17, Garrett Casto wrote:
> Nit: Generally this file just checks against kAliceUsername so that you don't
> have to do the conversion again.

Done.

[commit-bot: I haz the power, 2013-12-04 20:01:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jww@chromium.org/103503002/40001

[commit-bot: I haz the power, 2013-12-04 22:06:38]

Change committed as 238790