Ignore autocomplete='off' for usernames and passwords.

chrome/browser/password_manager/password_manager_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/message_loop/message_loop.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/password_manager/mock_password_store.h"
@@ skipping 83 matching lines @@
   }
 
   PasswordForm MakeSimpleForm() {
     PasswordForm form;
     form.origin = GURL("http://www.google.com/a/LoginAuth");
     form.action = GURL("http://www.google.com/a/Login");
     form.username_element = ASCIIToUTF16("Email");
     form.password_element = ASCIIToUTF16("Passwd");
     form.username_value = ASCIIToUTF16("google");
     form.password_value = ASCIIToUTF16("password");
-    // Default to true so we only need to add tests in autocomplete=off cases.
-    form.password_autocomplete_set = true;
     form.submit_element = ASCIIToUTF16("signIn");
     form.signon_realm = "http://www.google.com";
     return form;
   }
 
   // Reproduction of the form present on twitter's login page.
   PasswordForm MakeTwitterLoginForm() {
     PasswordForm form;
     form.origin = GURL("https://twitter.com/");
     form.action = GURL("https://twitter.com/sessions");
     form.username_element = ASCIIToUTF16("Email");
     form.password_element = ASCIIToUTF16("Passwd");
     form.username_value = ASCIIToUTF16("twitter");
     form.password_value = ASCIIToUTF16("password");
-    form.password_autocomplete_set = true;
     form.submit_element = ASCIIToUTF16("signIn");
     form.signon_realm = "https://twitter.com";
     return form;
   }
 
   // Reproduction of the form present on twitter's failed login page.
   PasswordForm MakeTwitterFailedLoginForm() {
     PasswordForm form;
     form.origin =
         GURL("https://twitter.com/login/error?redirect_after_login");
     form.action = GURL("https://twitter.com/sessions");
     form.username_element = ASCIIToUTF16("EmailField");
     form.password_element = ASCIIToUTF16("PasswdField");
     form.username_value = ASCIIToUTF16("twitter");
     form.password_value = ASCIIToUTF16("password");
-    form.password_autocomplete_set = true;
     form.submit_element = ASCIIToUTF16("signIn");
     form.signon_realm = "https://twitter.com";
     return form;
   }
 
   bool FormsAreEqual(const autofill::PasswordForm& lhs,
                      const autofill::PasswordForm& rhs) {
     if (lhs.origin != rhs.origin)
       return false;
     if (lhs.action != rhs.action)
       return false;
     if (lhs.username_element != rhs.username_element)
       return false;
     if (lhs.password_element != rhs.password_element)
       return false;
     if (lhs.username_value != rhs.username_value)
       return false;
     if (lhs.password_value != rhs.password_value)
       return false;
-    if (lhs.password_autocomplete_set != rhs.password_autocomplete_set)
-      return false;
     if (lhs.submit_element != rhs.submit_element)
       return false;
     if (lhs.signon_realm != rhs.signon_realm)
       return false;
     return true;
   }
 
   TestPasswordManager* manager() {
     return manager_;
   }
@@ skipping 16 matching lines @@
   MockPasswordManagerDelegate delegate_;  // Owned by manager_.
   PasswordForm submitted_form_;
 };
 
 MATCHER_P(FormMatches, form, "") {
   return form.signon_realm == arg.signon_realm &&
          form.origin == arg.origin &&
          form.action == arg.action &&
          form.username_element == arg.username_element &&
          form.password_element == arg.password_element &&
-         form.password_autocomplete_set ==
-             arg.password_autocomplete_set &&
          form.submit_element == arg.submit_element;
 }
 
 TEST_F(PasswordManagerTest, FormSubmitEmptyStore) {
   // Test that observing a newly submitted form shows the save password bar.
   std::vector<PasswordForm*> result;  // Empty password store.
   EXPECT_CALL(delegate_, FillPasswordForm(_)).Times(Exactly(0));
   EXPECT_CALL(*store_.get(), GetLogins(_, _))
       .WillOnce(DoAll(WithArg<1>(InvokeConsumer(result)), Return(1)));
   std::vector<PasswordForm> observed;
@@ skipping 289 matching lines @@
                            Value::CreateBooleanValue(false));
   EXPECT_CALL(delegate_, FillPasswordForm(_));
   EXPECT_CALL(*store_.get(), GetLogins(_, _))
       .WillRepeatedly(DoAll(WithArg<1>(InvokeConsumer(result)), Return(1)));
   std::vector<PasswordForm> observed;
   PasswordForm form(MakeSimpleForm());
   observed.push_back(form);
   manager()->OnPasswordFormsParsed(observed);
 }
 
-TEST_F(PasswordManagerTest, FormNotSavedAutocompleteOff) {
-  // Test password form with non-generated password will not be saved if
-  // autocomplete=off.
-  std::vector<PasswordForm*> result;  // Empty password store.
-  EXPECT_CALL(delegate_, FillPasswordForm(_)).Times(Exactly(0));
-  EXPECT_CALL(*store_.get(), GetLogins(_, _))
-      .WillOnce(DoAll(WithArg<1>(InvokeConsumer(result)), Return(1)));
-  std::vector<PasswordForm> observed;
-  PasswordForm form(MakeSimpleForm());
-  form.password_autocomplete_set = false;
-  observed.push_back(form);
-  manager()->OnPasswordFormsParsed(observed);  // The initial load.
-  manager()->OnPasswordFormsRendered(observed);  // The initial layout.
-
-  // And the form submit contract is to call ProvisionallySavePassword.
-  manager()->ProvisionallySavePassword(form);
-
-  // Password form should not be saved.
-  EXPECT_CALL(delegate_,
-              AddSavePasswordInfoBarIfPermitted(_)).Times(Exactly(0));
-  EXPECT_CALL(*store_.get(), AddLogin(FormMatches(form))).Times(Exactly(0));
-
-  // Now the password manager waits for the navigation to complete.
-  observed.clear();
-  manager()->OnPasswordFormsParsed(observed);  // The post-navigation load.
-  manager()->OnPasswordFormsRendered(observed);  // The post-navigation layout.
-}
-
-TEST_F(PasswordManagerTest, GeneratedPasswordFormSavedAutocompleteOff) {
-  // Test password form with generated password will still be saved if
-  // autocomplete=off.
-  std::vector<PasswordForm*> result;  // Empty password store.
-  EXPECT_CALL(delegate_, FillPasswordForm(_)).Times(Exactly(0));
-  EXPECT_CALL(*store_.get(), GetLogins(_, _))
-      .WillOnce(DoAll(WithArg<1>(InvokeConsumer(result)), Return(1)));
-  std::vector<PasswordForm> observed;
-  PasswordForm form(MakeSimpleForm());
-  form.password_autocomplete_set = false;
-  observed.push_back(form);
-  manager()->OnPasswordFormsParsed(observed);  // The initial load.
-  manager()->OnPasswordFormsRendered(observed);  // The initial layout.
-
-  // Simulate the user generating the password and submitting the form.
-  manager()->SetFormHasGeneratedPassword(form);
-  manager()->ProvisionallySavePassword(form);
-
-  // The user should not be presented with an infobar as they have already given
-  // consent by using the generated password. The form should be saved once
-  // navigation occurs.
-  EXPECT_CALL(delegate_,
-              AddSavePasswordInfoBarIfPermitted(_)).Times(Exactly(0));
-  EXPECT_CALL(*store_.get(), AddLogin(FormMatches(form)));
-
-  // Now the password manager waits for the navigation to complete.
-  observed.clear();
-  manager()->OnPasswordFormsParsed(observed);  // The post-navigation load.
-  manager()->OnPasswordFormsRendered(observed);  // The post-navigation layout.
-}
-
 TEST_F(PasswordManagerTest, SubmissionCallbackTest) {
   manager()->AddSubmissionCallback(SubmissionCallback());
   PasswordForm form = MakeSimpleForm();
   OnPasswordFormSubmitted(form);
   EXPECT_TRUE(FormsAreEqual(form, submitted_form_));
 }
 
 TEST_F(PasswordManagerTest, PasswordFormReappearance) {
   // Test the heuristic to know if a password form reappears.
   // We assume that if we send our credentials and there
@@ skipping 12 matching lines @@
   manager()->ProvisionallySavePassword(login_form);
 
   PasswordForm failed_login_form(MakeTwitterFailedLoginForm());
   observed.clear();
   observed.push_back(failed_login_form);
   // A PasswordForm appears, and is visible in the layout:
   // No expected calls to the PasswordStore...
   manager()->OnPasswordFormsParsed(observed);
   manager()->OnPasswordFormsRendered(observed);
 }