components/autofill/content/renderer/password_form_conversion_utils.cc - Issue 103503002: Ignore autocomplete='off' for usernames and passwords.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/password_form_conversion_utils.cc

Issue 103503002: Ignore autocomplete='off' for usernames and passwords. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Nits from gcasto Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/renderer/password_autofill_agent.cc ('k') | components/autofill/core/common/autofill_param_traits_macros.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/password_form_conversion_utils.cc

diff --git a/components/autofill/content/renderer/password_form_conversion_utils.cc b/components/autofill/content/renderer/password_form_conversion_utils.cc

index c54b84fca8d6c95dd3b95cc79e4f208d90076ef1..8b6c601c36ca1f5aaf7fc30b36c7d6cc66a6ec3f 100644

--- a/components/autofill/content/renderer/password_form_conversion_utils.cc

+++ b/components/autofill/content/renderer/password_form_conversion_utils.cc

@@ -32,8 +32,6 @@ scoped_ptr<PasswordForm> InitPasswordFormFromWebPasswordForm(

web_password_form.possibleUserNames.size());

password_form->password_element = web_password_form.passwordElement;

password_form->password_value = web_password_form.passwordValue;

- password_form->password_autocomplete_set =

- web_password_form.passwordShouldAutocomplete;

password_form->old_password_element = web_password_form.oldPasswordElement;

password_form->old_password_value = web_password_form.oldPasswordValue;

password_form->scheme = PasswordForm::SCHEME_HTML;