Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(998)

Unified Diff: chrome/browser/password_manager/password_manager.cc

Issue 103503002: Ignore autocomplete='off' for usernames and passwords. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Nits from gcasto Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_manager.cc
diff --git a/chrome/browser/password_manager/password_manager.cc b/chrome/browser/password_manager/password_manager.cc
index cf3b2b388d0457a66867cc4a787e214029dacf94..c2cc04ca39236150b53f1ea3936ea26249ab53fd 100644
--- a/chrome/browser/password_manager/password_manager.cc
+++ b/chrome/browser/password_manager/password_manager.cc
@@ -203,13 +203,7 @@ void PasswordManager::ProvisionallySavePassword(const PasswordForm& form) {
}
// Always save generated passwords, as the user expresses explicit intent for
- // Chrome to manage such passwords. For other passwords, respect the
- // autocomplete attribute.
- if (!manager->HasGeneratedPassword() && !form.password_autocomplete_set) {
- RecordFailure(AUTOCOMPLETE_OFF, form.origin.host());
- return;
- }
-
+ // Chrome to manage such passwords.
PasswordForm provisionally_saved_form(form);
provisionally_saved_form.ssl_valid = form.origin.SchemeIsSecure() &&
!delegate_->DidLastPageLoadEncounterSSLErrors();
« no previous file with comments | « chrome/browser/password_manager/password_manager.h ('k') | chrome/browser/password_manager/password_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698