Ignore autocomplete='off' for usernames and passwords.

chrome/renderer/autofill/password_autofill_agent_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/test/base/chrome_render_view_test.h"
 #include "components/autofill/content/renderer/autofill_agent.h"
 #include "components/autofill/content/renderer/form_autofill_util.h"
 #include "components/autofill/content/renderer/password_autofill_agent.h"
@@ skipping 114 matching lines @@
     "       <script type='text/javascript'>"
     "           function addParagraph() {"
     "             var p = document.createElement('p');"
     "             document.body.appendChild(p);"
     "            }"
     "           window.onload = addParagraph;"
     "       </script>"
     "   </body>"
     "</html>";
 
+const char kAutocompleteOffFormHTML[] =
+    "<FORM name='LoginTestForm' autocomplete='off'>"
+    "  <INPUT type='text' id='username'/>"
+    "  <INPUT type='password' id='password'/>"
+    "  <INPUT type='submit' value='Login'/>"
+    "</FORM>";
+
 const char kJavaScriptClick[] =
     "var event = new MouseEvent('click', {"
     "   'view': window,"
     "   'bubbles': true,"
     "   'cancelable': true"
     "});"
     "var form = document.getElementById('myform1');"
     "form.dispatchEvent(event);"
     "console.log('clicked!');";
 
@@ skipping 311 matching lines @@
       "<input type='text' id='username'/>"
       "<input type='password' id='password'/>";
   LoadHTML(kNoFormInputs);
 
   SimulateOnFillPasswordForm(fill_data_);
 
   // Input elements that aren't in a <form> won't autofill.
   CheckTextFieldsState(std::string(), false, std::string(), false);
 }
 
-// Tests that we do not autofill username/passwords if marked as
-// autocomplete="off".
-TEST_F(PasswordAutofillAgentTest, NoInitialAutocompleteForAutocompleteOff) {
+// Makes sure that we are ignoring autocomplete="off" on usernames and paswords.
+TEST_F(PasswordAutofillAgentTest, IgnoreElementAutocompleteOff) {
   username_element_.setAttribute(WebString::fromUTF8("autocomplete"),
                                  WebString::fromUTF8("off"));
+  password_element_.setAttribute(WebString::fromUTF8("autocomplete"),
+                                 WebString::fromUTF8("off"));
 
   // Simulate the browser sending back the login info, it triggers the
   // autocomplete.
   SimulateOnFillPasswordForm(fill_data_);
 
-  CheckTextFieldsState(std::string(), false, std::string(), false);
+  CheckTextFieldsState(
+      UTF16ToUTF8(username1_), true, UTF16ToUTF8(password1_), true);

[Garrett Casto, 2013/12/04 18:32:17]

Nit: Generally this file just checks against kAliceUsername so that you don't
have to do the conversion again.

[jww, 2013/12/04 20:00:57]

Done.

+}
+
+// Makes sure that we are ignoring autocomplete="off" on forms
+TEST_F(PasswordAutofillAgentTest, IgnoreFormAutocompleteOff) {
+  // We need to set the origin so it matches the frame URL and the action so
+  // it matches the form action, otherwise we won't autocomplete.
+  LoadHTML(kAutocompleteOffFormHTML);
+
+  // Retrieve the input elements so the test can access them.
+  WebDocument document = GetMainFrame()->document();
+  WebElement element =
+      document.getElementById(WebString::fromUTF8(kUsernameName));
+  ASSERT_FALSE(element.isNull());
+  username_element_ = element.to<blink::WebInputElement>();
+  element = document.getElementById(WebString::fromUTF8(kPasswordName));
+  ASSERT_FALSE(element.isNull());
+  password_element_ = element.to<blink::WebInputElement>();
+
+  // Set the expected form origin and action URLs.
+  std::string origin("data:text/html;charset=utf-8,");
+  origin += kAutocompleteOffFormHTML;
+  fill_data_.basic_data.origin = GURL(origin);
+  fill_data_.basic_data.action = GURL(origin);
+
+  // Simulate the browser sending back the login info, it triggers the
+  // autocomplete.
+  SimulateOnFillPasswordForm(fill_data_);
+
+  CheckTextFieldsState(
+      UTF16ToUTF8(username1_), true, UTF16ToUTF8(password1_), true);
 }
 
 TEST_F(PasswordAutofillAgentTest, NoAutocompleteForTextFieldPasswords) {
   const char kTextFieldPasswordFormHTML[] =
       "<FORM name='LoginTestForm' action='http://www.bidule.com'>"
       "  <INPUT type='text' id='username'/>"
       "  <INPUT type='text' id='password'/>"
       "  <INPUT type='submit' value='Login'/>"
       "</FORM>";
   LoadHTML(kTextFieldPasswordFormHTML);
@@ skipping 343 matching lines @@
 // Verfies that a DOM-activated UI event will not cause an autofill.
 TEST_F(PasswordAutofillAgentTest, NoDOMActivationTest) {
   // Trigger the initial autocomplete.
   SimulateOnFillPasswordForm(fill_data_);
 
   ExecuteJavaScript(kJavaScriptClick);
   CheckTextFieldsDOMState(kAliceUsername, true, "", true);
 }
 
 }  // namespace autofill