Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 103083002: Decouple FileSystem and WebSQL callbacks from VoidCallback and it non-refcounted (Closed)

Created:
7 years ago by adamk
Modified:
7 years ago
Reviewers:
abarth-chromium
CC:
blink-reviews, apavlov+blink_chromium.org, adamk+blink_chromium.org, aandrey+blink_chromium.org, Nils Barth (inactive), caseq+blink_chromium.org, Nate Chapin, arv+blink, yurys+blink_chromium.org, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, devtools-reviews_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, kinuko, eustas+blink_chromium.org, tommyw+watchlist_chromium.org, paulirish+reviews_chromium.org, haraken, kojih, jsbell+bindings_chromium.org, alph+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, Inactive, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

Decouple FileSystem and WebSQL callbacks from VoidCallback and make it non-refcounted Create two new VoidCallback clones in modules/filesystem and modules/webdatabase, and make the original non-refcounted. This will meet two goals: - The only code left using refcounted callbacks are in FileSystem and WebSQL - Evolving those two modules' use of callbacks into the modern age should be easier now that they're isolated from each other. R=abarth@chromium.org BUG=323681 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163132

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -98 lines) Patch
M Source/bindings/scripts/code_generator_v8.pm View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/Dictionary.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/Dictionary.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/VoidCallback.h View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/inspector/InspectorDatabaseAgent.cpp View 4 chunks +3 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorFileSystemAgent.cpp View 3 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/filesystem/DOMFileSystemBase.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/filesystem/DOMFileSystemBase.cpp View 4 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/filesystem/DirectoryEntry.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/filesystem/DirectoryEntry.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/filesystem/DirectoryEntry.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/Entry.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/modules/filesystem/Entry.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/filesystem/Entry.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/FileSystemCallbacks.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/filesystem/FileSystemCallbacks.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
A + Source/modules/filesystem/FileSystemVoidCallback.h View 1 chunk +4 lines, -4 lines 0 comments Download
A + Source/modules/filesystem/FileSystemVoidCallback.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/SyncCallbackHelper.h View 3 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/mediastream/RTCPeerConnection.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/mediastream/RTCPeerConnection.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/mediastream/RTCVoidRequestImpl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/mediastream/RTCVoidRequestImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/modules.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/modules/notifications/NotificationCenter.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/notifications/NotificationCenter.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/notifications/NotificationClient.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/Database.h View 3 chunks +5 lines, -6 lines 0 comments Download
M Source/modules/webdatabase/Database.cpp View 4 chunks +5 lines, -7 lines 0 comments Download
M Source/modules/webdatabase/Database.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/webdatabase/SQLTransaction.h View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/webdatabase/SQLTransaction.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
A + Source/modules/webdatabase/SQLVoidCallback.h View 1 chunk +4 lines, -4 lines 0 comments Download
A + Source/modules/webdatabase/SQLVoidCallback.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/NotificationPresenterImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/NotificationPresenterImpl.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
adamk
7 years ago (2013-12-03 22:21:20 UTC) #1
abarth-chromium
lgtm
7 years ago (2013-12-03 22:33:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/103083002/1
7 years ago (2013-12-03 22:33:51 UTC) #3
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years ago (2013-12-04 00:35:27 UTC) #4
adamk
7 years ago (2013-12-04 01:30:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r163132 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698