Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(919)

Unified Diff: Source/modules/notifications/NotificationCenter.cpp

Issue 103083002: Decouple FileSystem and WebSQL callbacks from VoidCallback and it non-refcounted (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/notifications/NotificationCenter.cpp
diff --git a/Source/modules/notifications/NotificationCenter.cpp b/Source/modules/notifications/NotificationCenter.cpp
index 12edf3eacc90aaf15b86b20a8e28610522681f97..081d1aa9246fedd00fc636a844823e96486e2c83 100644
--- a/Source/modules/notifications/NotificationCenter.cpp
+++ b/Source/modules/notifications/NotificationCenter.cpp
@@ -74,7 +74,7 @@ int NotificationCenter::checkPermission()
return m_client->checkPermission(executionContext());
}
-void NotificationCenter::requestPermission(PassRefPtr<VoidCallback> callback)
+void NotificationCenter::requestPermission(PassOwnPtr<VoidCallback> callback)
{
if (!client() || !executionContext())
return;
@@ -107,14 +107,14 @@ void NotificationCenter::requestTimedOut(NotificationCenter::NotificationRequest
m_callbacks.remove(request);
}
-PassRefPtr<NotificationCenter::NotificationRequestCallback> NotificationCenter::NotificationRequestCallback::createAndStartTimer(NotificationCenter* center, PassRefPtr<VoidCallback> callback)
+PassRefPtr<NotificationCenter::NotificationRequestCallback> NotificationCenter::NotificationRequestCallback::createAndStartTimer(NotificationCenter* center, PassOwnPtr<VoidCallback> callback)
{
RefPtr<NotificationCenter::NotificationRequestCallback> requestCallback = adoptRef(new NotificationCenter::NotificationRequestCallback(center, callback));
requestCallback->startTimer();
return requestCallback.release();
}
-NotificationCenter::NotificationRequestCallback::NotificationRequestCallback(NotificationCenter* center, PassRefPtr<VoidCallback> callback)
+NotificationCenter::NotificationRequestCallback::NotificationRequestCallback(NotificationCenter* center, PassOwnPtr<VoidCallback> callback)
: m_notificationCenter(center)
, m_timer(this, &NotificationCenter::NotificationRequestCallback::timerFired)
, m_callback(callback)
« no previous file with comments | « Source/modules/notifications/NotificationCenter.h ('k') | Source/modules/notifications/NotificationClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698