Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: Source/core/inspector/InspectorDatabaseAgent.cpp

Issue 103083002: Decouple FileSystem and WebSQL callbacks from VoidCallback and it non-refcounted (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/html/VoidCallback.h ('k') | Source/core/inspector/InspectorFileSystemAgent.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 12 matching lines...) Expand all
23 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND 23 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
24 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF 25 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
26 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 */ 27 */
28 28
29 #include "config.h" 29 #include "config.h"
30 #include "core/inspector/InspectorDatabaseAgent.h" 30 #include "core/inspector/InspectorDatabaseAgent.h"
31 31
32 #include "bindings/v8/ExceptionStatePlaceholder.h" 32 #include "bindings/v8/ExceptionStatePlaceholder.h"
33 #include "core/html/VoidCallback.h"
34 #include "core/inspector/InspectorDatabaseResource.h" 33 #include "core/inspector/InspectorDatabaseResource.h"
35 #include "core/inspector/InspectorState.h" 34 #include "core/inspector/InspectorState.h"
36 #include "core/inspector/InstrumentingAgents.h" 35 #include "core/inspector/InstrumentingAgents.h"
37 #include "core/loader/DocumentLoader.h" 36 #include "core/loader/DocumentLoader.h"
38 #include "core/frame/Frame.h" 37 #include "core/frame/Frame.h"
39 #include "core/page/Page.h" 38 #include "core/page/Page.h"
40 #include "modules/webdatabase/Database.h" 39 #include "modules/webdatabase/Database.h"
41 #include "modules/webdatabase/SQLError.h" 40 #include "modules/webdatabase/SQLError.h"
42 #include "modules/webdatabase/SQLResultSet.h" 41 #include "modules/webdatabase/SQLResultSet.h"
43 #include "modules/webdatabase/SQLResultSetRowList.h" 42 #include "modules/webdatabase/SQLResultSetRowList.h"
44 #include "modules/webdatabase/SQLStatementCallback.h" 43 #include "modules/webdatabase/SQLStatementCallback.h"
45 #include "modules/webdatabase/SQLStatementErrorCallback.h" 44 #include "modules/webdatabase/SQLStatementErrorCallback.h"
46 #include "modules/webdatabase/SQLTransaction.h" 45 #include "modules/webdatabase/SQLTransaction.h"
47 #include "modules/webdatabase/SQLTransactionCallback.h" 46 #include "modules/webdatabase/SQLTransactionCallback.h"
48 #include "modules/webdatabase/SQLTransactionErrorCallback.h" 47 #include "modules/webdatabase/SQLTransactionErrorCallback.h"
48 #include "modules/webdatabase/SQLVoidCallback.h"
49 #include "modules/webdatabase/sqlite/SQLValue.h" 49 #include "modules/webdatabase/sqlite/SQLValue.h"
50 #include "platform/JSONValues.h" 50 #include "platform/JSONValues.h"
51 #include "wtf/Vector.h" 51 #include "wtf/Vector.h"
52 52
53 typedef WebCore::InspectorBackendDispatcher::DatabaseCommandHandler::ExecuteSQLC allback ExecuteSQLCallback; 53 typedef WebCore::InspectorBackendDispatcher::DatabaseCommandHandler::ExecuteSQLC allback ExecuteSQLCallback;
54 54
55 namespace WebCore { 55 namespace WebCore {
56 56
57 namespace DatabaseAgentState { 57 namespace DatabaseAgentState {
58 static const char databaseAgentEnabled[] = "databaseAgentEnabled"; 58 static const char databaseAgentEnabled[] = "databaseAgentEnabled";
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
168 { 168 {
169 reportTransactionFailed(m_requestCallback.get(), error); 169 reportTransactionFailed(m_requestCallback.get(), error);
170 return true; 170 return true;
171 } 171 }
172 private: 172 private:
173 TransactionErrorCallback(PassRefPtr<ExecuteSQLCallback> requestCallback) 173 TransactionErrorCallback(PassRefPtr<ExecuteSQLCallback> requestCallback)
174 : m_requestCallback(requestCallback) { } 174 : m_requestCallback(requestCallback) { }
175 RefPtr<ExecuteSQLCallback> m_requestCallback; 175 RefPtr<ExecuteSQLCallback> m_requestCallback;
176 }; 176 };
177 177
178 class TransactionSuccessCallback : public VoidCallback { 178 class TransactionSuccessCallback : public SQLVoidCallback {
179 public: 179 public:
180 static PassRefPtr<TransactionSuccessCallback> create() 180 static PassRefPtr<TransactionSuccessCallback> create()
181 { 181 {
182 return adoptRef(new TransactionSuccessCallback()); 182 return adoptRef(new TransactionSuccessCallback());
183 } 183 }
184 184
185 virtual ~TransactionSuccessCallback() { } 185 virtual ~TransactionSuccessCallback() { }
186 186
187 virtual bool handleEvent() { return false; } 187 virtual bool handleEvent() { return false; }
188 188
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
291 } 291 }
292 292
293 Database* database = databaseForId(databaseId); 293 Database* database = databaseForId(databaseId);
294 if (!database) { 294 if (!database) {
295 requestCallback->sendFailure("Database not found"); 295 requestCallback->sendFailure("Database not found");
296 return; 296 return;
297 } 297 }
298 298
299 RefPtr<SQLTransactionCallback> callback(TransactionCallback::create(query, r equestCallback.get())); 299 RefPtr<SQLTransactionCallback> callback(TransactionCallback::create(query, r equestCallback.get()));
300 RefPtr<SQLTransactionErrorCallback> errorCallback(TransactionErrorCallback:: create(requestCallback.get())); 300 RefPtr<SQLTransactionErrorCallback> errorCallback(TransactionErrorCallback:: create(requestCallback.get()));
301 RefPtr<VoidCallback> successCallback(TransactionSuccessCallback::create()); 301 RefPtr<SQLVoidCallback> successCallback(TransactionSuccessCallback::create() );
302 database->transaction(callback.release(), errorCallback.release(), successCa llback.release()); 302 database->transaction(callback.release(), errorCallback.release(), successCa llback.release());
303 } 303 }
304 304
305 String InspectorDatabaseAgent::databaseId(Database* database) 305 String InspectorDatabaseAgent::databaseId(Database* database)
306 { 306 {
307 for (DatabaseResourcesMap::iterator it = m_resources.begin(); it != m_resour ces.end(); ++it) { 307 for (DatabaseResourcesMap::iterator it = m_resources.begin(); it != m_resour ces.end(); ++it) {
308 if (it->value->database() == database) 308 if (it->value->database() == database)
309 return it->key; 309 return it->key;
310 } 310 }
311 return String(); 311 return String();
(...skipping 10 matching lines...) Expand all
322 322
323 Database* InspectorDatabaseAgent::databaseForId(const String& databaseId) 323 Database* InspectorDatabaseAgent::databaseForId(const String& databaseId)
324 { 324 {
325 DatabaseResourcesMap::iterator it = m_resources.find(databaseId); 325 DatabaseResourcesMap::iterator it = m_resources.find(databaseId);
326 if (it == m_resources.end()) 326 if (it == m_resources.end())
327 return 0; 327 return 0;
328 return it->value->database(); 328 return it->value->database();
329 } 329 }
330 330
331 } // namespace WebCore 331 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/html/VoidCallback.h ('k') | Source/core/inspector/InspectorFileSystemAgent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698