Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1285)

Unified Diff: Source/core/inspector/InspectorDatabaseAgent.cpp

Issue 103083002: Decouple FileSystem and WebSQL callbacks from VoidCallback and it non-refcounted (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/VoidCallback.h ('k') | Source/core/inspector/InspectorFileSystemAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/InspectorDatabaseAgent.cpp
diff --git a/Source/core/inspector/InspectorDatabaseAgent.cpp b/Source/core/inspector/InspectorDatabaseAgent.cpp
index ba87ad4c873c2a99f1d75351786779285602009f..38e21c945d1e0f57bb1392650a84ece121475534 100644
--- a/Source/core/inspector/InspectorDatabaseAgent.cpp
+++ b/Source/core/inspector/InspectorDatabaseAgent.cpp
@@ -30,7 +30,6 @@
#include "core/inspector/InspectorDatabaseAgent.h"
#include "bindings/v8/ExceptionStatePlaceholder.h"
-#include "core/html/VoidCallback.h"
#include "core/inspector/InspectorDatabaseResource.h"
#include "core/inspector/InspectorState.h"
#include "core/inspector/InstrumentingAgents.h"
@@ -46,6 +45,7 @@
#include "modules/webdatabase/SQLTransaction.h"
#include "modules/webdatabase/SQLTransactionCallback.h"
#include "modules/webdatabase/SQLTransactionErrorCallback.h"
+#include "modules/webdatabase/SQLVoidCallback.h"
#include "modules/webdatabase/sqlite/SQLValue.h"
#include "platform/JSONValues.h"
#include "wtf/Vector.h"
@@ -175,7 +175,7 @@ private:
RefPtr<ExecuteSQLCallback> m_requestCallback;
};
-class TransactionSuccessCallback : public VoidCallback {
+class TransactionSuccessCallback : public SQLVoidCallback {
public:
static PassRefPtr<TransactionSuccessCallback> create()
{
@@ -298,7 +298,7 @@ void InspectorDatabaseAgent::executeSQL(ErrorString*, const String& databaseId,
RefPtr<SQLTransactionCallback> callback(TransactionCallback::create(query, requestCallback.get()));
RefPtr<SQLTransactionErrorCallback> errorCallback(TransactionErrorCallback::create(requestCallback.get()));
- RefPtr<VoidCallback> successCallback(TransactionSuccessCallback::create());
+ RefPtr<SQLVoidCallback> successCallback(TransactionSuccessCallback::create());
database->transaction(callback.release(), errorCallback.release(), successCallback.release());
}
« no previous file with comments | « Source/core/html/VoidCallback.h ('k') | Source/core/inspector/InspectorFileSystemAgent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698