Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Side by Side Diff: Source/modules/filesystem/FileSystemCallbacks.h

Issue 103083002: Decouple FileSystem and WebSQL callbacks from VoidCallback and it non-refcounted (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/modules/filesystem/Entry.idl ('k') | Source/modules/filesystem/FileSystemCallbacks.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 class DirectoryReaderBase; 44 class DirectoryReaderBase;
45 class EntriesCallback; 45 class EntriesCallback;
46 class EntryCallback; 46 class EntryCallback;
47 class ErrorCallback; 47 class ErrorCallback;
48 struct FileMetadata; 48 struct FileMetadata;
49 class FileSystemCallback; 49 class FileSystemCallback;
50 class FileWriterBase; 50 class FileWriterBase;
51 class FileWriterBaseCallback; 51 class FileWriterBaseCallback;
52 class MetadataCallback; 52 class MetadataCallback;
53 class ExecutionContext; 53 class ExecutionContext;
54 class VoidCallback; 54 class FileSystemVoidCallback;
55 55
56 class FileSystemCallbacksBase : public AsyncFileSystemCallbacks { 56 class FileSystemCallbacksBase : public AsyncFileSystemCallbacks {
57 public: 57 public:
58 virtual ~FileSystemCallbacksBase(); 58 virtual ~FileSystemCallbacksBase();
59 59
60 // For ErrorCallback. 60 // For ErrorCallback.
61 virtual void didFail(int code) OVERRIDE; 61 virtual void didFail(int code) OVERRIDE;
62 62
63 // Other callback methods are implemented by each subclass. 63 // Other callback methods are implemented by each subclass.
64 64
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 virtual void didCreateFileWriter(PassOwnPtr<blink::WebFileWriter>, long long length); 135 virtual void didCreateFileWriter(PassOwnPtr<blink::WebFileWriter>, long long length);
136 136
137 private: 137 private:
138 FileWriterBaseCallbacks(PassRefPtr<FileWriterBase>, PassRefPtr<FileWriterBas eCallback>, PassRefPtr<ErrorCallback>); 138 FileWriterBaseCallbacks(PassRefPtr<FileWriterBase>, PassRefPtr<FileWriterBas eCallback>, PassRefPtr<ErrorCallback>);
139 RefPtr<FileWriterBase> m_fileWriter; 139 RefPtr<FileWriterBase> m_fileWriter;
140 RefPtr<FileWriterBaseCallback> m_successCallback; 140 RefPtr<FileWriterBaseCallback> m_successCallback;
141 }; 141 };
142 142
143 class VoidCallbacks : public FileSystemCallbacksBase { 143 class VoidCallbacks : public FileSystemCallbacksBase {
144 public: 144 public:
145 static PassOwnPtr<AsyncFileSystemCallbacks> create(PassRefPtr<VoidCallback>, PassRefPtr<ErrorCallback>, DOMFileSystemBase*); 145 static PassOwnPtr<AsyncFileSystemCallbacks> create(PassRefPtr<FileSystemVoid Callback>, PassRefPtr<ErrorCallback>, DOMFileSystemBase*);
146 virtual void didSucceed(); 146 virtual void didSucceed();
147 147
148 private: 148 private:
149 VoidCallbacks(PassRefPtr<VoidCallback>, PassRefPtr<ErrorCallback>, DOMFileSy stemBase*); 149 VoidCallbacks(PassRefPtr<FileSystemVoidCallback>, PassRefPtr<ErrorCallback>, DOMFileSystemBase*);
150 RefPtr<VoidCallback> m_successCallback; 150 RefPtr<FileSystemVoidCallback> m_successCallback;
151 }; 151 };
152 152
153 } // namespace 153 } // namespace
154 154
155 #endif // FileSystemCallbacks_h 155 #endif // FileSystemCallbacks_h
OLDNEW
« no previous file with comments | « Source/modules/filesystem/Entry.idl ('k') | Source/modules/filesystem/FileSystemCallbacks.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698