Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 1025933002: Convert force video overlay to preference (Closed)

Created:
5 years, 9 months ago by boliu
Modified:
5 years, 9 months ago
CC:
android-webview-reviews_chromium.org, avayvod+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, gunsch+watch_chromium.org, jam, lcwu+watch_chromium.org, mcasas+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert force video overlay to preference This is a long lived command line switch that chromecast uses. Convert it to a RendererPreference instead. BUG=469343 Committed: https://crrev.com/77f844eb1e6df332344f12d385526b011530bfde Cr-Commit-Position: refs/heads/master@{#321923}

Patch Set 1 #

Patch Set 2 : fix #

Total comments: 4

Patch Set 3 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -37 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwSettings.java View 1 2 2 chunks +24 lines, -0 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenTest.java View 1 2 2 chunks +12 lines, -2 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/ExternalVideoSurfaceContainerTest.java View 3 chunks +2 lines, -5 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/MultipleVideosTest.java View 1 2 1 chunk +8 lines, -2 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/util/VideoSurfaceViewUtils.java View 2 chunks +0 lines, -10 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/util/VideoTestUtil.java View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M android_webview/native/aw_settings.cc View 1 2 1 chunk +6 lines, -1 line 0 comments Download
M chromecast/browser/android/cast_window_android.cc View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M chromecast/browser/cast_browser_main_parts.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromecast/browser/cast_content_browser_client.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/common/view_messages.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/common/renderer_preferences.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M content/public/common/renderer_preferences.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 3 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (6 generated)
boliu
ptal mnaganov - android_webview gunsch - chromecast sievers - content/public, content/common qinimn - content/renderer/media/android
5 years, 9 months ago (2015-03-23 17:35:57 UTC) #2
gunsch
On 2015/03/23 17:35:57, boliu wrote: > ptal > > mnaganov - android_webview > gunsch - ...
5 years, 9 months ago (2015-03-23 17:40:24 UTC) #3
mnaganov (inactive)
android_webview LGTM https://codereview.chromium.org/1025933002/diff/20001/android_webview/java/src/org/chromium/android_webview/AwSettings.java File android_webview/java/src/org/chromium/android_webview/AwSettings.java (right): https://codereview.chromium.org/1025933002/diff/20001/android_webview/java/src/org/chromium/android_webview/AwSettings.java#newcode1708 android_webview/java/src/org/chromium/android_webview/AwSettings.java:1708: public void setForceVideoOverlayForTests() { Should be maybe ...
5 years, 9 months ago (2015-03-23 17:44:22 UTC) #4
no sievers
lgtm https://codereview.chromium.org/1025933002/diff/20001/content/public/common/renderer_preferences.h File content/public/common/renderer_preferences.h (right): https://codereview.chromium.org/1025933002/diff/20001/content/public/common/renderer_preferences.h#newcode132 content/public/common/renderer_preferences.h:132: bool allow_video_overlay_for_embedded_encrypted_video; nit: Why are you changing it ...
5 years, 9 months ago (2015-03-23 18:42:11 UTC) #5
boliu
https://codereview.chromium.org/1025933002/diff/20001/android_webview/java/src/org/chromium/android_webview/AwSettings.java File android_webview/java/src/org/chromium/android_webview/AwSettings.java (right): https://codereview.chromium.org/1025933002/diff/20001/android_webview/java/src/org/chromium/android_webview/AwSettings.java#newcode1708 android_webview/java/src/org/chromium/android_webview/AwSettings.java:1708: public void setForceVideoOverlayForTests() { On 2015/03/23 17:44:22, mnaganov (cr) ...
5 years, 9 months ago (2015-03-23 18:57:30 UTC) #6
qinmin
webmediaplayer_android lgtm
5 years, 9 months ago (2015-03-23 21:42:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1025933002/40001
5 years, 9 months ago (2015-03-23 22:46:38 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/51448)
5 years, 9 months ago (2015-03-23 22:54:33 UTC) #12
boliu
+dcheng for content/common/view_messages.h
5 years, 9 months ago (2015-03-23 22:57:20 UTC) #14
dcheng
rs lgtm for ipc changes
5 years, 9 months ago (2015-03-24 02:17:51 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1025933002/40001
5 years, 9 months ago (2015-03-24 02:18:31 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-24 02:23:20 UTC) #18
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 02:24:17 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/77f844eb1e6df332344f12d385526b011530bfde
Cr-Commit-Position: refs/heads/master@{#321923}

Powered by Google App Engine
This is Rietveld 408576698