Convert force video overlay to preference

content/public/common/renderer_preferences.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // A struct for managing browser's settings that apply to the renderer or its
 // webview.  These differ from WebPreferences since they apply to Chromium's
 // glue layer rather than applying to just WebKit.
 //
 // Adding new values to this class probably involves updating
 // common/view_messages.h, browser/browser.cc, etc.
@@ skipping 111 matching lines @@
 
   // Disables rendering default error page when client choses to block a page.
   // Corresponds to net::ERR_BLOCKED_BY_CLIENT.
   bool disable_client_blocked_error_page;
 
   // Determines whether plugins are allowed to enter fullscreen mode.
   bool plugin_fullscreen_allowed;
 
   // Whether video-overlay (hole-punching) should be used for the embedded
   // encrypted video.  Currently only used by Android.
-  bool use_video_overlay_for_embedded_encrypted_video;
+  bool allow_video_overlay_for_embedded_encrypted_video;

[no sievers, 2015/03/23 18:42:11]

nit: Why are you changing it from 'use' to 'allow'?
Doesn't it always put encrypted video in an overlay if this is set?

[boliu, 2015/03/23 18:57:30]

Hmm, I think at one point, I was going for "allow" vs "force". Now that just
makes no sense anymore. I'll change it back.

+
+  // Use video-overlay (hole-punching) should be used for all video, not just
+  // encrypted video.  Currently only used by Android.
+  bool use_view_overlay_for_all_video;
 
   // The default system font settings for caption, small caption, menu and
   // status messages. Used only by Windows.
   base::string16 caption_font_family_name;
   int32 caption_font_height;
 
   base::string16 small_caption_font_family_name;
   int32 small_caption_font_height;
 
   base::string16 menu_font_family_name;
   int32 menu_font_height;
 
   base::string16 status_font_family_name;
   int32 status_font_height;
 
   base::string16 message_font_family_name;
   int32 message_font_height;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_COMMON_RENDERER_PREFERENCES_H_