android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java - Issue 1025933002: Convert force video overlay to preference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java

Issue 1025933002: Convert force video overlay to preference (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenTest.java ('k') | android_webview/javatests/src/org/chromium/android_webview/test/ExternalVideoSurfaceContainerTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java

index e0faf33482125a825b4eaf4251861a92ea5f084f..dbdbdaf394fcd002cb249447a43440d79c9d70a8 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java

@@ -2723,7 +2723,7 @@ public class AwSettingsTest extends AwTestBase {

@DisabledTest

public void testMediaPlaybackWithoutUserGesture() throws Throwable {

- assertTrue(VideoTestUtil.runVideoTest(this, false, WAIT_TIMEOUT_MS));

+ assertTrue(VideoTestUtil.runVideoTest(this, false, false, WAIT_TIMEOUT_MS));

}

@DisableHardwareAccelerationForTest

@@ -2731,7 +2731,7 @@ public class AwSettingsTest extends AwTestBase {

@Feature({"AndroidWebView", "Preferences"})

public void testMediaPlaybackWithUserGesture() throws Throwable {

// Wait for 5 second to see if video played.

- assertFalse(VideoTestUtil.runVideoTest(this, true, scaleTimeout(5000)));

+ assertFalse(VideoTestUtil.runVideoTest(this, true, false, scaleTimeout(5000)));

}

@SmallTest