Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Unified Diff: android_webview/native/aw_settings.cc

Issue 1025933002: Convert force video overlay to preference (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/native/aw_settings.cc
diff --git a/android_webview/native/aw_settings.cc b/android_webview/native/aw_settings.cc
index 91c506433427b749f3cc2fbe89fa1d0b8d3d338f..fb5488f9bdf445b7d4cfb6bc0813b524dd204a62 100644
--- a/android_webview/native/aw_settings.cc
+++ b/android_webview/native/aw_settings.cc
@@ -200,8 +200,13 @@ void AwSettings::UpdateRendererPreferencesLocked(JNIEnv* env, jobject obj) {
bool video_overlay =
Java_AwSettings_getVideoOverlayForEmbeddedVideoEnabledLocked(env, obj);
- if (video_overlay != prefs->use_video_overlay_for_embedded_encrypted_video) {
+ bool force_video_overlay =
+ Java_AwSettings_getForceVideoOverlayForTests(env, obj);
+ if (video_overlay !=
+ prefs->use_video_overlay_for_embedded_encrypted_video ||
+ force_video_overlay != prefs->use_view_overlay_for_all_video) {
prefs->use_video_overlay_for_embedded_encrypted_video = video_overlay;
+ prefs->use_view_overlay_for_all_video = force_video_overlay;
update_prefs = true;
}

Powered by Google App Engine
This is Rietveld 408576698