android_webview/javatests/src/org/chromium/android_webview/test/MultipleVideosTest.java - Issue 1025933002: Convert force video overlay to preference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/MultipleVideosTest.java

Issue 1025933002: Convert force video overlay to preference (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/ExternalVideoSurfaceContainerTest.java ('k') | android_webview/javatests/src/org/chromium/android_webview/test/util/VideoSurfaceViewUtils.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/MultipleVideosTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/MultipleVideosTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/MultipleVideosTest.java

index d0f4775d42da78bcd9d61b3eba567818f1fd76fe..954118d3eedd1c2c18ed1cf5955bd25bce839f5a 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/MultipleVideosTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/MultipleVideosTest.java

@@ -42,8 +42,14 @@ public class MultipleVideosTest extends AwTestBase {

@Feature({"AndroidWebView"})

public void testFirstVideoPausesWhenSecondVideoStarts()

throws Throwable {

- // To test video hole surfaces we must set force-flag before loading page.

- VideoSurfaceViewUtils.forceUseVideoHoleSurfaceView();

+ // To test video hole surfaces we must force video overlay before loading page.

+ getInstrumentation().runOnMainSync(new Runnable() {

+ @Override

+ public void run() {

+ mTestContainerView.getAwContents().getSettings().setForceVideoOverlayForTests(true);

+ }

+ });

loadTestPage();

// Play the first video.