Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1020683003: Make content::PermissionType an enum class. (Closed)

Created:
5 years, 9 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 9 months ago
CC:
android-webview-reviews_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org, markusheintz_, mkwst+moarreviews-shell_chromium.org, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make content::PermissionType an enum class. It allows us to forward declare it instead of including the file everywhere. BUG=437770 Committed: https://crrev.com/e2a873b6f8f4251a491891c5d5d825b25150a032 Cr-Commit-Position: refs/heads/master@{#322164}

Patch Set 1 #

Patch Set 2 : fix (some) compile issues #

Patch Set 3 : fix android compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -71 lines) Patch
M android_webview/browser/aw_content_browser_client.cc View 1 2 4 chunks +19 lines, -16 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 chunks +15 lines, -13 lines 0 comments Download
M chrome/browser/chrome_content_browser_client_unittest.cc View 1 4 chunks +16 lines, -11 lines 0 comments Download
M chrome/browser/content_settings/permission_context_uma_util.cc View 2 chunks +12 lines, -10 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/media/cdm/browser_cdm_manager.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/permissions/permission_service_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/permissions/permission_service_impl.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M content/public/browser/content_browser_client.h View 2 chunks +1 line, -1 line 0 comments Download
M content/public/browser/permission_type.h View 1 chunk +8 lines, -8 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_content_browser_client.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/layout_test/layout_test_content_browser_client.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/shell/browser/shell_content_browser_client.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (5 generated)
mlamouri (slow - plz ping)
jochen@, could you review these files: chrome/browser/content_settings/permission_context_uma_util.cc content/browser/frame_host/render_frame_host_impl.cc content/public/browser/content_browser_client.h content/public/browser/permission_type.h content/shell/browser/layout_test/layout_test_content_browser_client.cc content/shell/browser/layout_test/layout_test_content_browser_client.h content/shell/browser/shell_content_browser_client.cc torne@, could ...
5 years, 9 months ago (2015-03-24 16:12:39 UTC) #2
Torne
android_webview LGTM
5 years, 9 months ago (2015-03-24 16:36:32 UTC) #3
mlamouri (slow - plz ping)
Fixed some compile issues (hopefully all). PTAL>
5 years, 9 months ago (2015-03-25 10:27:04 UTC) #4
mlamouri (slow - plz ping)
Building locally for Android and Linux. PTAL.
5 years, 9 months ago (2015-03-25 11:45:36 UTC) #5
jochen (gone - plz use gerrit)
lgtm
5 years, 9 months ago (2015-03-25 12:29:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1020683003/40001
5 years, 9 months ago (2015-03-25 12:36:27 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/40118)
5 years, 9 months ago (2015-03-25 13:21:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1020683003/40001
5 years, 9 months ago (2015-03-25 13:55:27 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-25 15:06:24 UTC) #14
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 15:07:16 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e2a873b6f8f4251a491891c5d5d825b25150a032
Cr-Commit-Position: refs/heads/master@{#322164}

Powered by Google App Engine
This is Rietveld 408576698