content/shell/browser/layout_test/layout_test_content_browser_client.cc - Issue 1020683003: Make content::PermissionType an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/layout_test/layout_test_content_browser_client.cc

Issue 1020683003: Make content::PermissionType an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix android compile Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/browser/layout_test/layout_test_content_browser_client.h ('k') | content/shell/browser/shell_content_browser_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/browser/layout_test/layout_test_content_browser_client.cc

diff --git a/content/shell/browser/layout_test/layout_test_content_browser_client.cc b/content/shell/browser/layout_test/layout_test_content_browser_client.cc

index 82a04df6fc32b66c7b40aa4414dce17f01218d9b..938994538fe4ad73fe2f7bea1dd60ee2268fb691 100644

--- a/content/shell/browser/layout_test/layout_test_content_browser_client.cc

+++ b/content/shell/browser/layout_test/layout_test_content_browser_client.cc

@@ -7,6 +7,7 @@

#include "content/public/browser/browser_context.h"

#include "content/public/browser/browser_thread.h"

#include "content/public/browser/navigator_connect_context.h"

+#include "content/public/browser/permission_type.h"

#include "content/public/browser/render_process_host.h"

#include "content/public/browser/storage_partition.h"

#include "content/shell/browser/layout_test/layout_test_browser_context.h"

@@ -88,7 +89,7 @@ void LayoutTestContentBrowserClient::RequestPermission(

bool user_gesture,

const base::Callback<void(PermissionStatus)>& callback) {

DCHECK_CURRENTLY_ON(BrowserThread::UI);

- if (permission == content::PERMISSION_NOTIFICATIONS) {

+ if (permission == PermissionType::NOTIFICATIONS) {

BrowserThread::PostTask(

BrowserThread::IO,

FROM_HERE,