Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Unified Diff: content/public/browser/permission_type.h

Issue 1020683003: Make content::PermissionType an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix android compile Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/permission_type.h
diff --git a/content/public/browser/permission_type.h b/content/public/browser/permission_type.h
index c6e5c653501d087ef44fdd95d9323f0b2f987ba5..4fb062c44e78ae6af7b5773a723e7c7aba1ba739 100644
--- a/content/public/browser/permission_type.h
+++ b/content/public/browser/permission_type.h
@@ -11,16 +11,16 @@ namespace content {
// the UMA guidelines.
// Make sure you update histograms.xml if you add new permission types.
// Never delete or reorder an entry; only add new entries
-// immediately before PERMISSION_NUM
-enum PermissionType {
- PERMISSION_MIDI_SYSEX = 1,
- PERMISSION_PUSH_MESSAGING = 2,
- PERMISSION_NOTIFICATIONS = 3,
- PERMISSION_GEOLOCATION = 4,
- PERMISSION_PROTECTED_MEDIA_IDENTIFIER = 5,
+// immediately before PermissionType::NUM
+enum class PermissionType {
+ MIDI_SYSEX = 1,
+ PUSH_MESSAGING = 2,
+ NOTIFICATIONS = 3,
+ GEOLOCATION = 4,
+ PROTECTED_MEDIA_IDENTIFIER = 5,
// Always keep this at the end.
- PERMISSION_NUM,
+ NUM,
};
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698