Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: chrome/browser/content_settings/permission_context_uma_util.cc

Issue 1020683003: Make content::PermissionType an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix android compile Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/content_settings/permission_context_uma_util.cc
diff --git a/chrome/browser/content_settings/permission_context_uma_util.cc b/chrome/browser/content_settings/permission_context_uma_util.cc
index 2f4963844cfdb57962ea84a418436f8dfbbab939..3b62a904693dfbfe6209ad321861f3d7aab73202 100644
--- a/chrome/browser/content_settings/permission_context_uma_util.cc
+++ b/chrome/browser/content_settings/permission_context_uma_util.cc
@@ -98,20 +98,20 @@ void RecordPermissionRequest(
content::PermissionType type;
switch (permission) {
case CONTENT_SETTINGS_TYPE_GEOLOCATION:
- type = content::PERMISSION_GEOLOCATION;
+ type = content::PermissionType::GEOLOCATION;
break;
case CONTENT_SETTINGS_TYPE_NOTIFICATIONS:
- type = content::PERMISSION_NOTIFICATIONS;
+ type = content::PermissionType::NOTIFICATIONS;
break;
case CONTENT_SETTINGS_TYPE_MIDI_SYSEX:
- type = content::PERMISSION_MIDI_SYSEX;
+ type = content::PermissionType::MIDI_SYSEX;
break;
case CONTENT_SETTINGS_TYPE_PUSH_MESSAGING:
- type = content::PERMISSION_PUSH_MESSAGING;
+ type = content::PermissionType::PUSH_MESSAGING;
break;
#if defined(OS_ANDROID) || defined(OS_CHROMEOS)
case CONTENT_SETTINGS_TYPE_PROTECTED_MEDIA_IDENTIFIER:
- type = content::PERMISSION_PROTECTED_MEDIA_IDENTIFIER;
+ type = content::PermissionType::PROTECTED_MEDIA_IDENTIFIER;
break;
#endif
default:
@@ -119,17 +119,19 @@ void RecordPermissionRequest(
return;
}
UMA_HISTOGRAM_ENUMERATION(
- "ContentSettings.PermissionRequested", type, content::PERMISSION_NUM);
+ "ContentSettings.PermissionRequested",
+ static_cast<base::HistogramBase::Sample>(type),
+ static_cast<base::HistogramBase::Sample>(content::PermissionType::NUM));
if (secure_origin) {
UMA_HISTOGRAM_ENUMERATION(
"ContentSettings.PermissionRequested_SecureOrigin",
- type,
- content::PERMISSION_NUM);
+ static_cast<base::HistogramBase::Sample>(type),
+ static_cast<base::HistogramBase::Sample>(content::PermissionType::NUM));
} else {
UMA_HISTOGRAM_ENUMERATION(
"ContentSettings.PermissionRequested_InsecureOrigin",
- type,
- content::PERMISSION_NUM);
+ static_cast<base::HistogramBase::Sample>(type),
+ static_cast<base::HistogramBase::Sample>(content::PermissionType::NUM));
}
}
« no previous file with comments | « chrome/browser/chrome_content_browser_client_unittest.cc ('k') | content/browser/frame_host/render_frame_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698