Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(979)

Side by Side Diff: content/public/browser/permission_type.h

Issue 1020683003: Make content::PermissionType an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix android compile Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_PERMISSION_TYPE_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_PERMISSION_TYPE_H_
6 #define CONTENT_PUBLIC_BROWSER_PERMISSION_TYPE_H_ 6 #define CONTENT_PUBLIC_BROWSER_PERMISSION_TYPE_H_
7 7
8 namespace content { 8 namespace content {
9 9
10 // This enum is also used for UMA purposes, so it needs to adhere to 10 // This enum is also used for UMA purposes, so it needs to adhere to
11 // the UMA guidelines. 11 // the UMA guidelines.
12 // Make sure you update histograms.xml if you add new permission types. 12 // Make sure you update histograms.xml if you add new permission types.
13 // Never delete or reorder an entry; only add new entries 13 // Never delete or reorder an entry; only add new entries
14 // immediately before PERMISSION_NUM 14 // immediately before PermissionType::NUM
15 enum PermissionType { 15 enum class PermissionType {
16 PERMISSION_MIDI_SYSEX = 1, 16 MIDI_SYSEX = 1,
17 PERMISSION_PUSH_MESSAGING = 2, 17 PUSH_MESSAGING = 2,
18 PERMISSION_NOTIFICATIONS = 3, 18 NOTIFICATIONS = 3,
19 PERMISSION_GEOLOCATION = 4, 19 GEOLOCATION = 4,
20 PERMISSION_PROTECTED_MEDIA_IDENTIFIER = 5, 20 PROTECTED_MEDIA_IDENTIFIER = 5,
21 21
22 // Always keep this at the end. 22 // Always keep this at the end.
23 PERMISSION_NUM, 23 NUM,
24 }; 24 };
25 25
26 } // namespace content 26 } // namespace content
27 27
28 #endif // CONTENT_PUBLIC_BROWSER_PERMISSION_TYPE_H_ 28 #endif // CONTENT_PUBLIC_BROWSER_PERMISSION_TYPE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698