Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 1017163003: Add a warning for missing fileBrowserHandler permission. (Closed)

Created:
5 years, 9 months ago by mtomasz
Modified:
5 years, 9 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, rginda+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a warning for missing fileBrowserHandler permission. If file browser handlers are specified in the manifest, and the permission is missing, then they will be ignored. This CL adds a warning so users are aware of it. TEST=unit_tests: *FileBrowserHandlerManifestTest.InvalidFileBrowserHandlers* BUG=470494 Committed: https://crrev.com/dc219a796be153eeb36f34921f0f5bc107daf833 Cr-Commit-Position: refs/heads/master@{#322530}

Patch Set 1 #

Patch Set 2 : Fixed tests. #

Patch Set 3 : Restored manifest.json. #

Patch Set 4 : Comment out unused code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -37 lines) Patch
M chrome/common/extensions/api/file_browser_handlers/file_browser_handler.cc View 1 2 3 3 chunks +20 lines, -7 lines 0 comments Download
M chrome/common/extensions/api/file_browser_handlers/file_browser_handler_manifest_unittest.cc View 1 1 chunk +28 lines, -24 lines 0 comments Download
A + chrome/test/data/extensions/manifest_tests/filebrowser_invalid_value.json View 1 chunk +1 line, -2 lines 0 comments Download
A + chrome/test/data/extensions/manifest_tests/filebrowser_missing_permission.json View 1 chunk +1 line, -3 lines 0 comments Download
M extensions/common/manifest_constants.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/manifest_constants.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
mtomasz
@yoz: PTAL. Thanks.
5 years, 9 months ago (2015-03-26 02:07:58 UTC) #2
Yoyo Zhou
LGTM, thanks for following up.
5 years, 9 months ago (2015-03-26 18:31:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1017163003/1
5 years, 9 months ago (2015-03-26 23:25:52 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/49328)
5 years, 9 months ago (2015-03-27 00:49:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1017163003/20001
5 years, 9 months ago (2015-03-27 02:04:02 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/56182)
5 years, 9 months ago (2015-03-27 02:27:31 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1017163003/30008
5 years, 9 months ago (2015-03-27 02:45:52 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/37184)
5 years, 9 months ago (2015-03-27 03:04:06 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1017163003/50001
5 years, 9 months ago (2015-03-27 03:17:13 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:50001)
5 years, 9 months ago (2015-03-27 04:38:11 UTC) #21
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 04:38:51 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/dc219a796be153eeb36f34921f0f5bc107daf833
Cr-Commit-Position: refs/heads/master@{#322530}

Powered by Google App Engine
This is Rietveld 408576698