Add a warning for missing fileBrowserHandler permission.

chrome/common/extensions/api/file_browser_handlers/file_browser_handler.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/api/file_browser_handlers/file_browser_handler.h"
 
 #include "base/logging.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
 #include "chrome/common/extensions/extension_constants.h"
 #include "extensions/common/error_utils.h"
+#include "extensions/common/install_warning.h"
 #include "extensions/common/manifest.h"
 #include "extensions/common/manifest_constants.h"
 #include "extensions/common/manifest_handlers/permissions_parser.h"
 #include "extensions/common/permissions/api_permission.h"
 #include "extensions/common/url_pattern.h"
 #include "url/url_constants.h"
 
 namespace keys = extensions::manifest_keys;
 namespace errors = extensions::manifest_errors;
 
@@ skipping 100 matching lines @@
 
   return &info->file_browser_handlers;
 }
 
 FileBrowserHandlerParser::FileBrowserHandlerParser() {
 }
 
 FileBrowserHandlerParser::~FileBrowserHandlerParser() {
 }
 
+#if defined(OS_CHROMEOS)
 namespace {
 
 FileBrowserHandler* LoadFileBrowserHandler(
     const std::string& extension_id,
     const base::DictionaryValue* file_browser_handler,
     base::string16* error) {
   scoped_ptr<FileBrowserHandler> result(new FileBrowserHandler());
   result->set_extension_id(extension_id);
 
   std::string handler_id;
@@ skipping 117 matching lines @@
             extension_id,
             reinterpret_cast<base::DictionaryValue*>(*iter), error));
     if (!action.get())
       return false;  // Failed to parse file browser action definition.
     result->push_back(linked_ptr<FileBrowserHandler>(action.release()));
   }
   return true;
 }
 
 }  // namespace
+#endif
 
 bool FileBrowserHandlerParser::Parse(extensions::Extension* extension,
                                      base::string16* error) {
-  // If the permission is missing, then skip parsing the list of handlers.
-  if (!extensions::PermissionsParser::HasAPIPermission(
-          extension, extensions::APIPermission::ID::kFileBrowserHandler)) {
+#if !defined(OS_CHROMEOS)
+  return true;
+#else
+  const base::Value* file_browser_handlers_value = nullptr;
+  if (!extension->manifest()->Get(keys::kFileBrowserHandlers,
+                                  &file_browser_handlers_value)) {
     return true;
   }
 
-  const base::ListValue* file_browser_handlers_value = NULL;
-  if (!extension->manifest()->GetList(keys::kFileBrowserHandlers,
-                                      &file_browser_handlers_value)) {
+  if (!extensions::PermissionsParser::HasAPIPermission(
+          extension, extensions::APIPermission::ID::kFileBrowserHandler)) {
+    extension->AddInstallWarning(extensions::InstallWarning(
+        errors::kInvalidFileBrowserHandlerMissingPermission));
+    return true;
+  }
+
+  const base::ListValue* file_browser_handlers_list_value = nullptr;
+  if (!file_browser_handlers_value->GetAsList(
+          &file_browser_handlers_list_value)) {
     *error = base::ASCIIToUTF16(errors::kInvalidFileBrowserHandler);
     return false;
   }
 
   scoped_ptr<FileBrowserHandlerInfo> info(new FileBrowserHandlerInfo);
   if (!LoadFileBrowserHandlers(extension->id(),
-                               file_browser_handlers_value,
-                               &info->file_browser_handlers,
-                               error)) {
+                               file_browser_handlers_list_value,
+                               &info->file_browser_handlers, error)) {
     return false;  // Failed to parse file browser actions definition.
   }
 
   extension->SetManifestData(keys::kFileBrowserHandlers, info.release());
   return true;
+#endif
 }
 
 const std::vector<std::string> FileBrowserHandlerParser::Keys() const {
   return SingleKey(keys::kFileBrowserHandlers);
 }