extensions/common/manifest_constants.h - Issue 1017163003: Add a warning for missing fileBrowserHandler permission.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/manifest_constants.h

Issue 1017163003: Add a warning for missing fileBrowserHandler permission. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comment out unused code. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/manifest_tests/filebrowser_missing_permission.json ('k') | extensions/common/manifest_constants.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/manifest_constants.h

diff --git a/extensions/common/manifest_constants.h b/extensions/common/manifest_constants.h

index 87913969665664bca378c0cfbe2eed62099b91dc..36edf89d4101440d3ea1044135c7c7beccfb742a 100644

--- a/extensions/common/manifest_constants.h

+++ b/extensions/common/manifest_constants.h

@@ -302,7 +302,7 @@ extern const char kInvalidExportWhitelistString[];

extern const char kInvalidFileAccessList[];

extern const char kInvalidFileAccessValue[];

extern const char kInvalidFileBrowserHandler[];

-extern const char kInvalidFileBrowserHandlerMIMETypes[];

+extern const char kInvalidFileBrowserHandlerMissingPermission[];

extern const char kInvalidFileFiltersList[];

extern const char kInvalidFileFilterValue[];

extern const char kInvalidFileHandlers[];