Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: chrome/common/extensions/api/file_browser_handlers/file_browser_handler_manifest_unittest.cc

Issue 1017163003: Add a warning for missing fileBrowserHandler permission. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comment out unused code. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/file_browser_handlers/file_browser_handler_manifest_unittest.cc
diff --git a/chrome/common/extensions/api/file_browser_handlers/file_browser_handler_manifest_unittest.cc b/chrome/common/extensions/api/file_browser_handlers/file_browser_handler_manifest_unittest.cc
index cfcaeef4e7466036b9ab695392784c2db69d835a..18f6aba7f21bf2dee9da2d188c87e7d92e12e8a4 100644
--- a/chrome/common/extensions/api/file_browser_handlers/file_browser_handler_manifest_unittest.cc
+++ b/chrome/common/extensions/api/file_browser_handlers/file_browser_handler_manifest_unittest.cc
@@ -73,31 +73,35 @@ TEST_F(FileBrowserHandlerManifestTest, GetHandlersRequiresPermission) {
TEST_F(FileBrowserHandlerManifestTest, InvalidFileBrowserHandlers) {
Testcase testcases[] = {
- Testcase("filebrowser_invalid_access_permission.json",
- extensions::ErrorUtils::FormatErrorMessage(
- errors::kInvalidFileAccessValue, base::IntToString(1))),
- Testcase("filebrowser_invalid_access_permission_list.json",
- errors::kInvalidFileAccessList),
- Testcase("filebrowser_invalid_empty_access_permission_list.json",
- errors::kInvalidFileAccessList),
- Testcase("filebrowser_invalid_actions_1.json",
- errors::kInvalidFileBrowserHandler),
- Testcase("filebrowser_invalid_actions_2.json",
- errors::kInvalidFileBrowserHandler),
- Testcase("filebrowser_invalid_action_id.json",
- errors::kInvalidPageActionId),
- Testcase("filebrowser_invalid_action_title.json",
- errors::kInvalidPageActionDefaultTitle),
- Testcase("filebrowser_invalid_file_filters_1.json",
- errors::kInvalidFileFiltersList),
- Testcase("filebrowser_invalid_file_filters_2.json",
- extensions::ErrorUtils::FormatErrorMessage(
- errors::kInvalidFileFilterValue, base::IntToString(0))),
- Testcase("filebrowser_invalid_file_filters_url.json",
- extensions::ErrorUtils::FormatErrorMessage(
- errors::kInvalidURLPatternError, "http:*.html"))
- };
+ Testcase("filebrowser_invalid_access_permission.json",
+ extensions::ErrorUtils::FormatErrorMessage(
+ errors::kInvalidFileAccessValue, base::IntToString(1))),
+ Testcase("filebrowser_invalid_access_permission_list.json",
+ errors::kInvalidFileAccessList),
+ Testcase("filebrowser_invalid_empty_access_permission_list.json",
+ errors::kInvalidFileAccessList),
+ Testcase("filebrowser_invalid_value.json",
+ errors::kInvalidFileBrowserHandler),
+ Testcase("filebrowser_invalid_actions_1.json",
+ errors::kInvalidFileBrowserHandler),
+ Testcase("filebrowser_invalid_actions_2.json",
+ errors::kInvalidFileBrowserHandler),
+ Testcase("filebrowser_invalid_action_id.json",
+ errors::kInvalidPageActionId),
+ Testcase("filebrowser_invalid_action_title.json",
+ errors::kInvalidPageActionDefaultTitle),
+ Testcase("filebrowser_invalid_file_filters_1.json",
+ errors::kInvalidFileFiltersList),
+ Testcase("filebrowser_invalid_file_filters_2.json",
+ extensions::ErrorUtils::FormatErrorMessage(
+ errors::kInvalidFileFilterValue, base::IntToString(0))),
+ Testcase("filebrowser_invalid_file_filters_url.json",
+ extensions::ErrorUtils::FormatErrorMessage(
+ errors::kInvalidURLPatternError, "http:*.html"))};
RunTestcases(testcases, arraysize(testcases), EXPECT_TYPE_ERROR);
+ RunTestcase(Testcase("filebrowser_missing_permission.json",
+ errors::kInvalidFileBrowserHandlerMissingPermission),
+ EXPECT_TYPE_WARNING);
}
TEST_F(FileBrowserHandlerManifestTest, ValidFileBrowserHandler) {

Powered by Google App Engine
This is Rietveld 408576698