chrome/test/data/extensions/manifest_tests/filebrowser_missing_permission.json - Issue 1017163003: Add a warning for missing fileBrowserHandler permission.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/manifest_tests/filebrowser_missing_permission.json

Issue 1017163003: Add a warning for missing fileBrowserHandler permission. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comment out unused code. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/manifest_tests/filebrowser_invalid_value.json ('k') | extensions/common/manifest_constants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/manifest_tests/filebrowser_missing_permission.json

diff --git a/chrome/test/data/extensions/manifest_tests/filebrowser_invalid_action_id.json b/chrome/test/data/extensions/manifest_tests/filebrowser_missing_permission.json

similarity index 81%

copy from chrome/test/data/extensions/manifest_tests/filebrowser_invalid_action_id.json

copy to chrome/test/data/extensions/manifest_tests/filebrowser_missing_permission.json

index dbd3ee82330a6570dc3f3a92a72058496de63456..86e0384ce9417ff9c3946b0949985205e53bc2d7 100644

--- a/chrome/test/data/extensions/manifest_tests/filebrowser_invalid_action_id.json

+++ b/chrome/test/data/extensions/manifest_tests/filebrowser_missing_permission.json

@@ -1,11 +1,9 @@

{

"name": "test",

"version": "1",

- "permissions": [

- "fileBrowserHandler"

- ],

"file_browser_handlers": [

{

+ "id": "test",

"default_title" : "Test",

"default_icon" : "icon.png",

"file_filters" : [