Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1016443002: De-duplicate BASE_IMPLEMENTATION define in the GN build. (Closed)

Created:
5 years, 9 months ago by brettw
Modified:
5 years, 9 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, erikwright+watch_chromium.org, gavinp+memory_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

De-duplicate BASE_IMPLEMENTATION define in the GN build. TBR=ncbray Committed: https://crrev.com/dda803bdc8674978b49f1be479e5807a5cc0d7f4 Cr-Commit-Position: refs/heads/master@{#320771}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -14 lines) Patch
M base/BUILD.gn View 1 2 3 6 chunks +8 lines, -6 lines 0 comments Download
M base/debug/BUILD.gn View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M base/json/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M base/memory/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M base/metrics/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M base/process/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M base/third_party/nspr/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M base/trace_event/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
brettw
5 years, 9 months ago (2015-03-16 17:43:15 UTC) #2
Nick Bray (chromium)
LGTM
5 years, 9 months ago (2015-03-16 18:07:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1016443002/60001
5 years, 9 months ago (2015-03-16 19:13:47 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-16 19:18:33 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 19:19:04 UTC) #7
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/dda803bdc8674978b49f1be479e5807a5cc0d7f4
Cr-Commit-Position: refs/heads/master@{#320771}

Powered by Google App Engine
This is Rietveld 408576698