base/debug/BUILD.gn - Issue 1016443002: De-duplicate BASE_IMPLEMENTATION define in the GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/debug/BUILD.gn

Issue 1016443002: De-duplicate BASE_IMPLEMENTATION define in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/debug/BUILD.gn

diff --git a/base/debug/BUILD.gn b/base/debug/BUILD.gn

index 0de41ad6ef75556e556a8386ebcd9aded7e6ece0..8ed623b03f9e973ca60772cc8aa8d821d9dd115f 100644

--- a/base/debug/BUILD.gn

+++ b/base/debug/BUILD.gn

@@ -55,7 +55,7 @@ source_set("debug") {

]

}

- defines = [ "BASE_IMPLEMENTATION" ]

+ configs += [ "//base:base_implementation" ]

deps = [

"//base/memory",

@@ -63,7 +63,7 @@ source_set("debug") {

]

if (is_linux) {

- defines += [ "USE_SYMBOLIZE" ]

+ defines = [ "USE_SYMBOLIZE" ]

deps += [ "//base/third_party/symbolize" ]

}

« no previous file with comments | « base/BUILD.gn ('k') | base/json/BUILD.gn » ('j') | no next file with comments »