Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Side by Side Diff: base/third_party/nspr/BUILD.gn

Issue 1016443002: De-duplicate BASE_IMPLEMENTATION define in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/process/BUILD.gn ('k') | base/trace_event/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 source_set("nspr") { 5 source_set("nspr") {
6 visibility = [ "//base/*" ] 6 visibility = [ "//base/*" ]
7 7
8 sources = [ 8 sources = [
9 "prtime.cc", 9 "prtime.cc",
10 "prtime.h", 10 "prtime.h",
11 ] 11 ]
12 12
13 # In GYP this project is part of base, so it uses the base implementation 13 # In GYP this project is part of base, so it uses the base implementation
14 # define. TODO(brettw) rename this define. 14 # define. TODO(brettw) rename this define.
15 defines = [ "BASE_IMPLEMENTATION" ] 15 configs += [ "//base:base_implementation" ]
16 16
17 if (is_android && !is_debug) { 17 if (is_android && !is_debug) {
18 configs -= [ "//build/config/compiler:optimize" ] 18 configs -= [ "//build/config/compiler:optimize" ]
19 configs += [ "//build/config/compiler:optimize_max" ] 19 configs += [ "//build/config/compiler:optimize_max" ]
20 } 20 }
21 } 21 }
OLDNEW
« no previous file with comments | « base/process/BUILD.gn ('k') | base/trace_event/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698